Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small VPN Criteria cleanup #1771

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Small VPN Criteria cleanup #1771

merged 1 commit into from
Sep 16, 2022

Conversation

matchboxbananasynergy
Copy link
Contributor

This PR:

  • Removes mention of F-droid from VPN criteria. If our criteria is that VPN clients should be open-source, that's completely fine. Mentioning F-droid by name, however, when we currently issue a lot of warnings and caveats about it felt off.
  • Renames "Hidden Service" to "Onion Service", as that is the correct terminology now.

@matchboxbananasynergy matchboxbananasynergy temporarily deployed to preview September 16, 2022 10:45 Inactive
@github-actions
Copy link

github-actions bot commented Sep 16, 2022 •
edited

🎊 PR Preview b3a2544 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1771.surge.sh

🕐 Build time: 79.169s

🤖 By surge-preview

freddy-m
freddy-m approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dngray dngray added the t:correction content corrections or errors label Sep 16, 2022
@matchboxbananasynergy @dngray
Change hidden to onion, remove F-droid mention (#1771)
b3a2544 
Signed-off-by: Daniel Gray <dng@disroot.org>
@dngray dngray temporarily deployed to preview September 16, 2022 13:05 Inactive
@dngray dngray merged commit b3a2544 into privacyguides:main Sep 16, 2022
@matchboxbananasynergy matchboxbananasynergy deleted the pr-vpn-criteria-cleanup branch September 16, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddy-m freddy-m freddy-m approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
t:correction content corrections or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matchboxbananasynergy @freddy-m @dngray