-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing review of threat-modeling.en.md #1819
Writing review of threat-modeling.en.md #1819
Conversation
🎊 PR Preview 64c7e30 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1819.surge.sh 🕐 Build time: 71.395s 🤖 By surge-preview |
Doesn't matter, we can squash them into one before merging, so it's all good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Co-authored-by: matchboxbananasynergy <107055883+matchboxbananasynergy@users.noreply.github.com> Signed-off-by: Daniel Gray <dng@disroot.org>
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Edit: Please ignore my messy commit history (unless it unknowingly affects my pull request)!
Summary
6 "et cetera" --> "etc.", as per APA style.
6 Missing comma: subordinate clause.
8 Missing comma: embedded clause.
10 Missing comma: subordinate clause.
12 "security/privacy" --> "security and privacy", as per APA Style.
12 "potential" is redundant here: "could" expresses modality.
14 Simplified sentence structure: conciseness.
16 Updated to title case.
18 "want to" --> "should", as per style guide.
18 Are "those who might want to get ahold of your assets" not covered by the stressed definition of "adversary"? I couldn't think of a counter-example, so I omitted this for conciseness.
46 Removed "a": conciseness.
46 Missing commas: embedded clause.
46 Removed "at any likelihood": redundancy (already implied).
56 Added "of": accuracy.
56 Missing comma: embedded clause.
68 Partially updated to title case: "Protecting your belongings" reads like a title, whereas "Try it yourself:" is consistent with the tone of the other H3 headings (which are in sentence case).
72 Missing comma: subordinate clause.
82 "roommates/guests" --> "roommates or guests", as per APA Style.
86 "these" --> "those": accuracy.