Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing review of threat-modeling.en.md #1819

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Writing review of threat-modeling.en.md #1819

merged 1 commit into from
Sep 30, 2022

Conversation

KaiTebay
Copy link
Contributor

@KaiTebay KaiTebay commented Sep 28, 2022

Edit: Please ignore my messy commit history (unless it unknowingly affects my pull request)!

Summary

6 "et cetera" --> "etc.", as per APA style.
6 Missing comma: subordinate clause.
8 Missing comma: embedded clause.
10 Missing comma: subordinate clause.
12 "security/privacy" --> "security and privacy", as per APA Style.
12 "potential" is redundant here: "could" expresses modality.
14 Simplified sentence structure: conciseness.
16 Updated to title case.
18 "want to" --> "should", as per style guide.
18 Are "those who might want to get ahold of your assets" not covered by the stressed definition of "adversary"? I couldn't think of a counter-example, so I omitted this for conciseness.
46 Removed "a": conciseness.
46 Missing commas: embedded clause.
46 Removed "at any likelihood": redundancy (already implied).
56 Added "of": accuracy.
56 Missing comma: embedded clause.
68 Partially updated to title case: "Protecting your belongings" reads like a title, whereas "Try it yourself:" is consistent with the tone of the other H3 headings (which are in sentence case).
72 Missing comma: subordinate clause.
82 "roommates/guests" --> "roommates or guests", as per APA Style.
86 "these" --> "those": accuracy.

  • Please check this box to confirm you have disclosed any relevant conflicts of interest in your post.
  • Please check this box to confirm your agreement to publish your work under the Creative Commons Attribution-NoDerivatives 4.0 International license, and to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform and distribute your contribution as part of our project.

@KaiTebay KaiTebay temporarily deployed to preview September 28, 2022 16:28 Inactive
@KaiTebay KaiTebay changed the title Writing review of thread-modeling.en.md Writing review of threat-modeling.en.md Sep 28, 2022
@github-actions
Copy link

github-actions bot commented Sep 28, 2022

🎊 PR Preview 64c7e30 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1819.surge.sh

🕐 Build time: 71.395s

🤖 By surge-preview

@freddy-m freddy-m self-assigned this Sep 28, 2022
@freddy-m freddy-m added the c:enhancements new features or other enhancements to the website itself label Sep 28, 2022
@matchboxbananasynergy matchboxbananasynergy added t:correction content corrections or errors and removed c:enhancements new features or other enhancements to the website itself labels Sep 28, 2022
@dngray
Copy link
Member

dngray commented Sep 29, 2022

Edit: Please ignore my messy commit history (unless it unknowingly affects my pull request)!

Doesn't matter, we can squash them into one before merging, so it's all good.

@KaiTebay KaiTebay temporarily deployed to preview September 29, 2022 08:30 Inactive
@KaiTebay KaiTebay closed this Sep 29, 2022
@KaiTebay KaiTebay deleted the writing-review-thread-modeling branch September 29, 2022 19:22
@KaiTebay KaiTebay restored the writing-review-thread-modeling branch September 29, 2022 19:24
@matchboxbananasynergy matchboxbananasynergy temporarily deployed to preview September 29, 2022 19:31 Inactive
Copy link
Member

@blacklight447 blacklight447 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Co-authored-by: matchboxbananasynergy <107055883+matchboxbananasynergy@users.noreply.github.com>
Signed-off-by: Daniel Gray <dng@disroot.org>
@dngray dngray temporarily deployed to preview September 30, 2022 11:18 Inactive
@dngray dngray merged commit 64c7e30 into privacyguides:main Sep 30, 2022
@KaiTebay KaiTebay deleted the writing-review-thread-modeling branch September 30, 2022 13:17
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.org/t/v2-27/1084/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants