Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise OpenWrt card #1827

Merged
merged 5 commits into from Oct 2, 2022
Merged

Revise OpenWrt card #1827

merged 5 commits into from Oct 2, 2022

Conversation

JustLuckNoSkill
Copy link
Contributor

  • Please check this box to confirm you have disclosed any relevant conflicts of interest in your post.
  • Please check this box to confirm your agreement to publish your work under the Creative Commons Attribution-NoDerivatives 4.0 International license, and to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform and distribute your contribution as part of our project.

This PR streamlines the OpenWrt card without removing any information.

Streamlines OpenWrt recommendation without removing information.
@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 1, 2022 03:41 Inactive
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

🎊 PR Preview 4efaa01 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1827.surge.sh

🕐 Build time: 88.44s

🤖 By surge-preview

@JustLuckNoSkill JustLuckNoSkill marked this pull request as ready for review October 1, 2022 03:45
Copy link
Contributor

@KaiTebay KaiTebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my suggestion, this looks good to me!

docs/router.en.md Outdated Show resolved Hide resolved
@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 1, 2022 21:30 Inactive
@matchboxbananasynergy
Copy link
Contributor

I think it's weird not to start the card with the name of the recommendation, even though it fits our writing style... tough decision here.

@KaiTebay
Copy link
Contributor

KaiTebay commented Oct 2, 2022

I think it's weird not to start the card with the name of the recommendation, even though it fits our writing style... tough decision here.
@matchboxbananasynergy

That's a really good point. How about this: the card could begin with the name of the recommendation while also using active voice!

OpenWrt is a Linux-based operating system; it's primarily used on embedded devices (to route network traffic).

@matchboxbananasynergy
Copy link
Contributor

matchboxbananasynergy commented Oct 2, 2022

I think it's weird not to start the card with the name of the recommendation, even though it fits our writing style... tough decision here.
@matchboxbananasynergy

That's a really good point. How about this: the card could begin with the name of the recommendation while also using active voice!

OpenWrt is a Linux-based operating system; it's primarily used on embedded devices (to route network traffic).

@KaiTebay That is much better. Question: does it need the parenthesis for "to route network traffic"?

I feel like "OpenWrt is a Linux-based operating system; it's primarily used on embedded devices to route network traffic." also works and looks much better. Is there some grammatical nuance I'm missing here?

@JustLuckNoSkill
Copy link
Contributor Author

JustLuckNoSkill commented Oct 2, 2022

I feel like "OpenWrt is a Linux-based operating system; it's primarily used on embedded devices to route network traffic." also works and looks much better. Is there some grammatical nuance I'm missing here?

@matchboxbananasynergy This looks good to me.

@KaiTebay
Copy link
Contributor

KaiTebay commented Oct 2, 2022

That is much better. Question: does it need the parenthesis for "to route network traffic"?

I feel like "OpenWrt is a Linux-based operating system; it's primarily used on embedded devices to route network traffic." also works and looks much better. Is there some grammatical nuance I'm missing here?
@matchboxbananasynergy

Not at all: good catch. I did this before my morning coffee. 😅
It looks great to me!

@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 2, 2022 12:09 Inactive
@matchboxbananasynergy matchboxbananasynergy merged commit df90475 into privacyguides:main Oct 2, 2022
@JustLuckNoSkill JustLuckNoSkill deleted the OpenWrt-revision branch October 3, 2022 19:45
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.org/t/v2-27/1084/1

@dngray dngray added c:os operating systems and related topics t:correction content corrections or errors labels Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:os operating systems and related topics t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants