-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise OpenWrt card #1827
Revise OpenWrt card #1827
Conversation
Streamlines OpenWrt recommendation without removing information.
🎊 PR Preview 4efaa01 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1827.surge.sh 🕐 Build time: 88.44s 🤖 By surge-preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my suggestion, this looks good to me!
I think it's weird not to start the card with the name of the recommendation, even though it fits our writing style... tough decision here. |
That's a really good point. How about this: the card could begin with the name of the recommendation while also using active voice!
|
@KaiTebay That is much better. Question: does it need the parenthesis for "to route network traffic"? I feel like "OpenWrt is a Linux-based operating system; it's primarily used on embedded devices to route network traffic." also works and looks much better. Is there some grammatical nuance I'm missing here? |
@matchboxbananasynergy This looks good to me. |
Not at all: good catch. I did this before my morning coffee. 😅 |
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
This PR streamlines the OpenWrt card without removing any information.