Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Neo Store in DivestOS recommendation #1829

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Mention Neo Store in DivestOS recommendation #1829

merged 1 commit into from
Oct 9, 2022

Conversation

JustLuckNoSkill
Copy link
Contributor

  • Please check this box to confirm you have disclosed any relevant conflicts of interest in your post.
  • Please check this box to confirm your agreement to publish your work under the Creative Commons Attribution-NoDerivatives 4.0 International license, and to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform and distribute your contribution as part of our project.

The current DivestOS recommendation lists F-Droid as a positive, which contradicts the F-Droid section at the bottom of the Android page. This PR adds a warning against using F-Droid despite it being installed by default. Alternatively, the F-Droid mention could be deleted entirely.

@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 3, 2022 21:18 Inactive
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

🎊 PR Preview 226b9f7 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1829.surge.sh

🕐 Build time: 100.246s

🤖 By surge-preview

@JustLuckNoSkill JustLuckNoSkill marked this pull request as ready for review October 3, 2022 21:22
@matchboxbananasynergy
Copy link
Contributor

Thank you for spotting this. We should re-word this, but it is not a black-and-white situation when it comes to DivestOS, because they use their own F-Droid repo to distribute and update their own software, so we cannot suggest that people disable or not use F-Droid on DivestOS.

It might perhaps make sense to suggest that people disable it and use Neo Store instead, if that's possible, but I don't know what the best course of action is. Perhaps @SkewedZeppelin can provide some more information/guidance here.

@matchboxbananasynergy matchboxbananasynergy marked this pull request as draft October 4, 2022 13:18
@dngray dngray added the t:correction content corrections or errors label Oct 4, 2022
@SkewedZeppelin
Copy link
Contributor

SkewedZeppelin commented Oct 4, 2022

There is a section here on this: https://divestos.org/index.php?page=faq#altDroid

tl;dr without it users won't have browser or WebView updates

I recently went through and checked 8 of the alternative clients and none of them support repository overrides like F-Droid does.

@matchboxbananasynergy
Copy link
Contributor

@SkewedZeppelin If we were to theoretically recommend that people disabled F-Droid, installed Neo Store and enabled the necessary repos, would there be a problem with that? Or do you think it's best that people stick with the default configuration.

I cannot remember off the top of my head whether you use F-Droid's privileged extension or not, are updates of these components unattended?

@SkewedZeppelin
Copy link
Contributor

SkewedZeppelin commented Oct 4, 2022

@matchboxbananasynergy
As long as users add the repos I don't care what client they use.

PrivExt was removed in April, so updates aren't unattended.

@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 4, 2022 19:15 Inactive
@SkewedZeppelin
Copy link
Contributor

SkewedZeppelin commented Oct 4, 2022

The updated version still isn't correct and would result in users missing critical WebView updates.

The available (Sept 10th) builds of DivestOS are currently shipping Chromium 105.0.5195.79.
But I've pushed out 105.0.5195.124, 105.0.5195.136, 106.0.5249.65, and 106.0.5249.79 via the WebView repo since then: https://divestos.org/misc/ch-dates.txt

@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 4, 2022 19:23 Inactive
@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 4, 2022 19:30 Inactive
@JustLuckNoSkill JustLuckNoSkill marked this pull request as ready for review October 4, 2022 19:34
@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 4, 2022 19:43 Inactive
@JustLuckNoSkill JustLuckNoSkill changed the title Warn against using F-Droid in DivestOS Recommendation Mention Neo Store in DivestOS recommendation Oct 4, 2022
@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 4, 2022 20:23 Inactive
@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 4, 2022 21:27 Inactive
@matchboxbananasynergy
Copy link
Contributor

matchboxbananasynergy commented Oct 4, 2022

@SkewedZeppelin What do you think about the wording now? My only concern is that people may improperly configure Neo Store and not enable the DivestOS repos as we instruct and end up missing critical security updates. On the other hand, I'd prefer that people didn't leave the official F-Droid app enabled due to its SDK and other issues. (I am correct in assuming that the F-Droid app can be disabled but not uninstalled, right?)

Also, another question I had is why are there two separate repos instead of including everything in one repo?

@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 4, 2022 21:38 Inactive
@SkewedZeppelin
Copy link
Contributor

SkewedZeppelin commented Oct 4, 2022

What do you think about the wording now?

Wording could be a bit stronger, but looks fine.

I am correct in assuming that the F-Droid app can be installed but not uninstalled, right?

Default installed, can be disabled.

two separate repos

When I switched to the Mulch webview I wanted to maintain compatibility with all previous builds (because some users sadly only update every few months, and I didn't want any transition period), this mean signing the WebView for each device. So there are actually 120+ copies of the WebView apk in the repo.
Furthermore fdroidserver is very slow and buggy at processing Chromium apks, so it is actually a patched version to allow it to even generate and separate to prevent taking 5 minutes to regenerate for updates of the other apps.

It also has the benefit that if for some reason (like the time they broke scrolling for some apps) there is a bad webview update, I can just move the old repo back into place.
For example you can see the previous version still there: https://divestos.org/fdroid/webview-106.0.5249.65-1/index-v1.json

And lastly the official repo contains apps that can be used on any device, no need to clutter with with DivestOS specific apps.

docs/android.en.md Outdated Show resolved Hide resolved
Copy link
Member

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should provide a link somewhere there, to what these "security issues" are. This will be a contentious topic amongst free software enthusiasts.

@JustLuckNoSkill JustLuckNoSkill temporarily deployed to preview October 5, 2022 20:41 Inactive
@matchboxbananasynergy
Copy link
Contributor

Not sure if we should link to the wonderfall article in the DivestOS section when we mention the security issues with F-Droid, or if we should just have a link to our F-Droid section below, especially as there are plans to expand it with more context/info. Thoughts @dngray?

@dngray
Copy link
Member

dngray commented Oct 7, 2022

Not sure if we should link to the wonderfall article in the DivestOS section when we mention the security issues with F-Droid, or if we should just have a link to our F-Droid section below, especially as there are plans to expand it with more context/info. Thoughts @dngray?

I'm thinking expand the section on the android page to be a brief synopsis of some of the points in the wonderfall article. We should elaborate on that sentence:

However, there are notable problems with the official F-Droid client, their quality control, and how they build, sign, and deliver packages.

I think I would like to see this sentence elaborated into a single paragraph. The wonderfall article is quite lengthy, and I think its points won't be read by readers. I'm not saying we need to mention all of the points there, but I do think 1-3 are most relevant. Especially 3.

@matchboxbananasynergy matchboxbananasynergy temporarily deployed to preview October 7, 2022 06:15 Inactive
@dngray dngray temporarily deployed to preview October 9, 2022 17:46 Inactive
Signed-off-by: Daniel Gray <dng@disroot.org>
@dngray dngray merged commit 226b9f7 into privacyguides:main Oct 9, 2022
@dngray dngray temporarily deployed to preview October 9, 2022 17:49 Inactive
@JustLuckNoSkill JustLuckNoSkill deleted the divest-no-f-droid branch October 9, 2022 20:21
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.org/t/v2-27/1084/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants