Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pricing from Proton Mail card #1832

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Remove pricing from Proton Mail card #1832

merged 1 commit into from
Oct 7, 2022

Conversation

matchboxbananasynergy
Copy link
Contributor

This PR removes the mention of a specific price for Proton Mail, as we've recently opted to remove specific pricing from the website to make things easier to maintain.

  • Please check this box to confirm you have disclosed any relevant conflicts of interest in your post.
  • Please check this box to confirm your agreement to publish your work under the Creative Commons Attribution-NoDerivatives 4.0 International license, and to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform and distribute your contribution as part of our project.

@matchboxbananasynergy matchboxbananasynergy temporarily deployed to preview October 7, 2022 12:00 Inactive
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

🎊 PR Preview 0f8a953 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1832.surge.sh

🕐 Build time: 94.881s

🤖 By surge-preview

@blacklight447
Copy link
Member

Where is the discussion about this removal?

@matchboxbananasynergy
Copy link
Contributor Author

@blacklight447

Initial discussion turned issue:
#1737

PR where some comments where made and after discussion it was decided that it makes sense to just link to the websites and let people find the pricing from the source:
https://github.com/privacyguides/privacyguides.org/pull/1806

PR that removed pricing from existing cards:
#1811

Listing the pricing ourselves is hard to maintain, as a long of services change their prices, or have sales etc. Furthermore, we used to list some prices in EUR and some prices in USD which was inconsistent. Also, some services support multiple different currencies, so by only listing one, we might be giving people the wrong idea about that.

This PR just addresses an instance where we mention pricing that was overlooked in the PR that removed it from most places.

@freddy-m freddy-m merged commit 2f82e64 into privacyguides:main Oct 7, 2022
@matchboxbananasynergy matchboxbananasynergy deleted the pr-proton-pricing branch October 7, 2022 17:58
dngray pushed a commit that referenced this pull request Oct 9, 2022
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.org/t/v2-27/1084/1

@dngray dngray added c:providers service providers and similar centralized/federated services t:correction content corrections or errors labels Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:providers service providers and similar centralized/federated services t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants