-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing review of common-threats.en.md #1836
Conversation
🎊 PR Preview 812558d has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1836.surge.sh 🕐 Build time: 79.109s 🤖 By surge-preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These re-wordings generally LGTM. I think there's a lot of comma over-use in this PR, and I suggested a few other minor changes as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through this, and I think it's a vast improvement on readability.
docs/basics/common-threats.en.md
Outdated
|
||
## Privacy From Service Providers | ||
|
||
<span class="pg-teal">:material-server-network: Service Providers</span> | ||
|
||
We live in a world where almost everything is connected to the internet. Our "private" messages, emails, social interactions are typically stored on a server somewhere. Generally, when you send someone a message, that message is then stored on a server, and when your friend wants to read the message, the server will show it to them. | ||
We live in a world where almost everything is connected to the internet. Our messages, emails, and social interactions are typically stored on a server, somewhere. Generally, when you send someone a message, it's then stored on a server; when your friend wants to read the message, the server will show it to them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree, but this is the same issue as #1836 (comment) I think?
Co-authored-by: Jonah Aragon <github@aragon.science> Signed-off-by: Daniel Gray <dng@disroot.org> Signed-off-by: matchboxbananasynergy <107055883+matchboxbananasynergy@users.noreply.github.com>
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Notes
Need citation:
References (with further information) would be helpful: