Fix Note on Brave Tor Window Setting #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
datoshkr
commented
Oct 15, 2022
•
datoshkr
commented
- Please check this box to confirm you have disclosed any relevant conflicts of interest in your post.
- Please check this box to confirm your agreement to publish your work under the Creative Commons Attribution-NoDerivatives 4.0 International license, and to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform and distribute your contribution as part of our project.
|
🎊 PR Preview 22f4046 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1841.surge.sh 🕐 Build time: 78.932s
🤖 By surge-preview |
|
It took me a bit to understand what this PR was trying to fix, but I eventually got it. A recent PR moved the Tor window section from one section of the settings to another, and we didn't have the necessary code for the note to be handled appropriately. It should now be fine and the same as the "block scripts" option above it. Thank you for spotting this and trying to help fix it! |
matchboxbananasynergy
changed the title
matchboxbananasynergy
approved these changes
Oct 15, 2022
ghost
approved these changes
Oct 16, 2022
dngray
added
c:browsers
|
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.