Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About category changes #1875

Merged
merged 13 commits into from
Nov 1, 2022
Merged

About category changes #1875

merged 13 commits into from
Nov 1, 2022

Conversation

jonaharagon
Copy link
Member

Related to https://discuss.privacyguides.org/t/github-wiki/6207

  • Please check this box to confirm you have disclosed any relevant conflicts of interest in your post.
  • Please check this box to confirm your agreement to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute your contribution as part of our project.
  • Please check this box to confirm you are the sole author of this work, or that any additional authors will also reply to this PR on GitHub confirming their agreement to these terms.

@netlify
Copy link

netlify bot commented Oct 26, 2022 •
edited
Loading

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 2fca248
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/636193db9a08120007f4b2bf
😎 Deploy Preview https://deploy-preview-1875--privacyguides.netlify.app/about
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@freddy-m freddy-m self-requested a review October 26, 2022 12:19
freddy-m
freddy-m approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will this exist along with a GitHub wiki, or will that be shelved?

@jonaharagon jonaharagon marked this pull request as ready for review October 30, 2022 21:17
blacklight447
blacklight447 reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@blacklight447 blacklight447 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, but wouldn't we want to add profile pictures as well?

@jonaharagon @matchboxbananasynergy
@matchboxbananasynergy profile
201bd37 
Co-authored-by: matchboxbananasynergy <107055883+matchboxbananasynergy@users.noreply.github.com>
@freddy-m
Copy link
Member

Not sure PFPs are needed, but website links could be cool 👀

ghost
ghost suggested changes Oct 31, 2022
View reviewed changes
docs/about/index.md Show resolved Hide resolved
@matchboxbananasynergy
Copy link
Contributor

I made changes to the uploading-images.md page in the inkscape section so that it better conforms to our writing style, but I'm not sure if I like it...

@freddy-m freddy-m mentioned this pull request Nov 1, 2022
Closed
3 tasks
@jonaharagon @KaiTebay
@KaiTebay profile
2fca248 
Co-authored-by: Kai Tebay <95620167+KaiTebay@users.noreply.github.com>
@jonaharagon jonaharagon merged commit 4f86633 into main Nov 1, 2022
@jonaharagon jonaharagon deleted the jonaharagon/about-meta branch November 1, 2022 21:54
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v2-28/8091/1

IkelAtomig pushed a commit to IkelAtomig/privacyguides.org that referenced this pull request Nov 11, 2022
@jonaharagon @freddy-m
@matchboxbananasynergy @KaiTebay @IkelAtomig
About category changes (privacyguides#1875)
d06ec22 
Co-authored-by: Freddy <freddy@privacyguides.org>
Co-authored-by: matchboxbananasynergy <107055883+matchboxbananasynergy@users.noreply.github.com>
Co-authored-by: mfwmyfacewhen <94880365+mfwmyfacewhen@users.noreply.github.com>
Co-authored-by: Kai Tebay <95620167+KaiTebay@users.noreply.github.com>
IkelAtomig pushed a commit to IkelAtomig/privacyguides.org that referenced this pull request Nov 13, 2022
@jonaharagon @freddy-m
@matchboxbananasynergy @KaiTebay @IkelAtomig
About category changes (privacyguides#1875)
050679f 
Co-authored-by: Freddy <freddy@privacyguides.org>
Co-authored-by: matchboxbananasynergy <107055883+matchboxbananasynergy@users.noreply.github.com>
Co-authored-by: mfwmyfacewhen <94880365+mfwmyfacewhen@users.noreply.github.com>
Co-authored-by: Kai Tebay <95620167+KaiTebay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiTebay KaiTebay KaiTebay left review comments

@matchboxbananasynergy matchboxbananasynergy matchboxbananasynergy left review comments

@freddy-m freddy-m freddy-m approved these changes

@blacklight447 blacklight447 blacklight447 approved these changes

@dngray dngray Awaiting requested review from dngray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jonaharagon @freddy-m @matchboxbananasynergy @privacyguides-bot @blacklight447 @KaiTebay