Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Windows & Linux download for briar desktop #1961

Merged
merged 1 commit into from Feb 6, 2023
Merged

Adds Windows & Linux download for briar desktop #1961

merged 1 commit into from Feb 6, 2023

Conversation

jacobgonzales20
Copy link
Contributor

  • Please check this box to confirm you have disclosed any relevant conflicts of interest in your post.
  • Please check this box to confirm your agreement to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute your contribution as part of our project.
  • Please check this box to confirm you are the sole author of this work, or that any additional authors will also reply to this PR on GitHub confirming their agreement to these terms.

@jacobgonzales20 jacobgonzales20 changed the title adds windows download for briar adds windows download for briar desktop Jan 31, 2023
@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit a1e40a7
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/63e0c515b76e460009ac25fe
😎 Deploy Preview https://deploy-preview-1961--privacyguides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jacobgonzales20
Copy link
Contributor Author

Alternatively, this can be changed to https://desktop.briarproject.org/msis/Briar-Desktop.msi for direct download

@dngray
Copy link
Member

dngray commented Feb 1, 2023

We don't direct link to the installer, but we can now mention Linux too as it seems they're updating their installers now more regularly.

@jacobgonzales20
Copy link
Contributor Author

We don't direct link to the installer, but we can now mention Linux too as it seems they're updating their installers now more regularly.

In my commit it's not a direct download it's a page which allows the user to choose, but currently the downloads shows flathub (Linux) this new commit adds the new windows download .msi

@jacobgonzales20 jacobgonzales20 changed the title adds windows download for briar desktop adds windows & linux download for briar desktop Feb 1, 2023
@jacobgonzales20 jacobgonzales20 changed the title adds windows & linux download for briar desktop Adds windows & Linux download for briar desktop Feb 1, 2023
@jacobgonzales20 jacobgonzales20 changed the title Adds windows & Linux download for briar desktop Adds Windows & Linux download for briar desktop Feb 1, 2023
@ghost ghost added the c:software self-hosted/decentralized software and related topics label Feb 3, 2023
@ghost
Copy link

ghost commented Feb 4, 2023

I'm not sure why we want the same link multiple times.

@matchboxbananasynergy
Copy link
Contributor

How else would you indicate that the same link contains both a Linux and Windows download?

@ghost
Copy link

ghost commented Feb 4, 2023

How else would you indicate that the same link contains both a Linux and Windows download?

Just a "Downloads" button.

@matchboxbananasynergy
Copy link
Contributor

How else would you indicate that the same link contains both a Linux and Windows download?

Just a "Downloads" button.

Where would that lead in the case of Briar?

@dngray
Copy link
Member

dngray commented Feb 6, 2023

I'm not sure why we want the same link multiple times.

It's okay, customarily when the download link is the same for each platform, we just duplicate it.

Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit a1e40a7 into privacyguides:main Feb 6, 2023
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v2-31/11698/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:software self-hosted/decentralized software and related topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants