Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave corrections, additions and fixes #2115

Merged
merged 4 commits into from Apr 7, 2023
Merged

Brave corrections, additions and fixes #2115

merged 4 commits into from Apr 7, 2023

Conversation

ticklemyIP
Copy link
Contributor

@ticklemyIP ticklemyIP commented Apr 6, 2023

Changes proposed in this PR:

Add and fix annotations and correct the IPFS menu title for consistency. Also added the Always use secure connection toggle to mobile-browsers.md.

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

IPFS menu location changed in Brave, also I put the IPFS explanation into annotation to be consistent with the mobile-browsers.md (which is currently broken). 

Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
I suppose it couldn't hurt. Also this way it's consistent with desktop-browsers.md.

Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit b5b1689
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/642f5c3fc734380008599cf5
😎 Deploy Preview https://deploy-preview-2115--privacyguides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: ticklemyIP <126688461+ticklemyIP@users.noreply.github.com>
@jonaharagon
Copy link
Member

jonaharagon commented Apr 7, 2023

Why are the changes to desktop-browser.md preferable to the current version?

Comment on lines 85 to +86
- [x] Select **Upgrade connections to HTTPS**
- [x] Select **Always use secure connections**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do both of these settings exist on Android...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@jonaharagon jonaharagon merged commit b480475 into privacyguides:main Apr 7, 2023
4 checks passed
@ticklemyIP ticklemyIP deleted the brave-patch branch April 11, 2023 20:35
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-8/12304/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants