Download translations dynamically #2120
Conversation
✅ Deploy Preview for privacyguides ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jonaharagon
force-pushed
the
jonaharagon/crowdin-netlify-download
branch
from
9051363
to
555ac66
Compare
jonaharagon
force-pushed
the
jonaharagon/crowdin-netlify-download
branch
from
555ac66
to
aade832
Compare
|
Whats the pro here actually? As i don't think repo size matters that much honestly. |
|
@blacklight447 the advantages are a cleaner commit history and changelog; less manual work since we wouldn't have to check translations on here and Crowdin; less confusion about where files should be edited, because currently there are a lot of files which can not be manually edited on GitHub (only on Crowdin) so there's no reason for them to exist here; changes on Crowdin can be previewed on Netlify much easier (for example changes to the upcoming #2111 Spanish translation would be preview-able live quicker); and that the translated versions of the site will be updated much quicker when changes to the main site are made, instead of outdated information and missing pages sitting on them until the next language release. The disadvantage is that translations won't be manually reviewed via PR here before going live. I'm unsure whether this is a big risk since we don't accept translations from unapproved contributors (not that the approval process is particularly rigorous, but it is a roadblock to spam bots/trolls at least). Also, longer Netlify build times. |
|
Thanks for clearing it up. |
|
This would also allow us to trigger a new Netlify build as soon as a file hits 100% in Crowdin. https://store.crowdin.com/netlify |
jonaharagon
force-pushed
the
jonaharagon/crowdin-netlify-download
branch
from
aade832
to
2df3405
Compare
privacyguides-bot
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Removes translations from this Git repo, Netlify will download them from Crowdin automatically every time it builds the site (at the expense of making Netlify previews take much longer lol)