Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recommend Orbot IsolateDestAddr #2121

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

jonaharagon
Copy link
Member

@jonaharagon jonaharagon commented Apr 10, 2023

Changes proposed in this PR:

  • Remove the recommendation to enable Isolate Destination Address in Orbot, which is not best practice

I think that was originally added in #390 (comment)


Isolating by destination address is also ridiculously expensive and
slow if you're doing typical HTTP usage, or some other protocol where
a single logical request turns into requests to many different hosts.
Mike's got a more sophisticated approach here that he's aiming to do
in TB; he can link to the best explanation of it better than I can
find out which one is best.

Usually, unless you know better, you are better off not using IsolateDestAddr or IsolateDestPort.

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit fc12732
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/643555480d18c10008cc999b
😎 Deploy Preview https://deploy-preview-2121--privacyguides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dngray dngray added c:software self-hosted/decentralized software and related topics t:correction content corrections or errors labels Apr 11, 2023
Signed-off-by: Freddy <freddy@privacyguides.org>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray force-pushed the jonaharagon/orbot-isolatedestaddr branch from cbf4755 to fc12732 Compare April 11, 2023 12:40
@dngray dngray merged commit fc12732 into main Apr 11, 2023
7 checks passed
@dngray dngray deleted the jonaharagon/orbot-isolatedestaddr branch April 11, 2023 12:41
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-8/12304/1

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/recommend-enabling-isolation-options-in-orbot/15283/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:software self-hosted/decentralized software and related topics t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants