Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accrescent & Play Store Link For IVPN #2139

Merged
merged 1 commit into from Apr 21, 2023
Merged

Add Accrescent & Play Store Link For IVPN #2139

merged 1 commit into from Apr 21, 2023

Conversation

matchboxbananasynergy
Copy link
Contributor

Changes proposed in this PR:

This PR replaces https://www.ivpn.net/apps-android/ link with direct Play Store and Accrescent download links. Direct Play Store link was chosen for consistency with other entries across the site, and Accrescent was added as IVPN made it onto the store.

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 7de8b90
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/64426497fa7d6000086f1b82
😎 Deploy Preview https://deploy-preview-2139.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ghost
ghost previously approved these changes Apr 19, 2023
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accrescent isn't a recommended app store, it shouldn't have been added in #1957 either.

@ghost ghost dismissed their stale review April 20, 2023 03:24

accrescent hasn't been approved yet

@matchboxbananasynergy
Copy link
Contributor Author

matchboxbananasynergy commented Apr 20, 2023

Accrescent isn't a recommended app store, it shouldn't have been added in #1957 either.

Prior to posting the ExifEraser Accrescent PR, I'd spoken to team members and asked if this was desirable, please talk amongst yourselves and come to a consensus, or it could be discussed on the forum, if that's preferable.

I don't have strong feelings either way, but my interpretation of how it works currently is that it's okay to list a download location that's not explicitly recommended against (see F-Droid). Play Store itself is not a recommended app store, but I'm assuming that the insinuation here is that Aurora Store fills that role, which is fair enough.

I don't know if this is the same, but there are other parts of the site in which download locations are recommended for systems that Privacy Guides doesn't recommend, such as Nextcloud having a FreeBSD link: https://www.privacyguides.org/en/file-sharing/#nextcloud-client-server

I don't necessarily think that having a download link to a source means you recommend it. If you recommended Accrescent as an overall app store, it would be in the Android page. However, if an app is choosing to publish there, and it's not a source you explicitly recommend against, I personally don't see the harm in it being included.

Anyway, happy to discuss further.

Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to open a forum discussion about just recommending Accrescent in general 👍

I've changed my mind about this, it does make sense if the download link is recommended by the developer.

@dngray
Copy link
Member

dngray commented Apr 20, 2023

I've added a discussion thread for Accrescent. While we may not list this specifically on the Android page, I think it's okay to still list downloads for the few applications where installation with Accrescent is possible as it does make updating those apps hugely more convenient (if you don't want to get them from Google Play) or bother with the RSS feed method.

@dngray dngray added the c:software self-hosted/decentralized software and related topics label Apr 21, 2023
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit 7de8b90 into privacyguides:main Apr 21, 2023
@matchboxbananasynergy matchboxbananasynergy deleted the pr-ivpn-accrescent branch April 21, 2023 10:28
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-10/12551/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:software self-hosted/decentralized software and related topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants