Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SSH commit signing instructions #2265

Merged
merged 3 commits into from Oct 14, 2023

Conversation

nopeitsnothing
Copy link
Contributor

Changes proposed in this PR:

  • Add alternative for SSH signing in git for WSL

This PR is to suggest a WSL method for assigning a SSH git key using the xclip command, rather than pbcopy.
Saves people time figuring out Ubuntu doesn't have the pbcopy package, and is pretty straightforward.

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 60e0c2c
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/651ddf56bc29eb0008920ea4
😎 Deploy Preview https://deploy-preview-2265.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dngray
Copy link
Member

dngray commented Aug 16, 2023

This PR is to suggest a WSL method for assigning a SSH git key using the xclip command, rather than pbcopy.
Saves people time figuring out Ubuntu doesn't have the pbcopy package, and is pretty straightforward.

Perhaps we should make some mention of wl-copy from Ubuntu and Fedora.

@nopeitsnothing
Copy link
Contributor Author

This PR is to suggest a WSL method for assigning a SSH git key using the xclip command, rather than pbcopy.
Saves people time figuring out Ubuntu doesn't have the pbcopy package, and is pretty straightforward.

Perhaps we should make some mention of wl-copy from Ubuntu and Fedora.

More the merrier. :>

Signed-off-by: Jonah Aragon <jonah@triplebit.net>
@jonaharagon jonaharagon changed the title Add alternative for SSH signing in git for WSL Improve SSH commit signing instructions Oct 4, 2023
Signed-off-by: Jonah Aragon <jonah@triplebit.net>
@ph00lt0
Copy link
Contributor

ph00lt0 commented Oct 6, 2023

what is wrong with cat? and just copying it after, works on my (and your) machine

@jonaharagon
Copy link
Member

mm, instead I've just updated this PR to have the command point to a file containing your public key, rather than pasting your public key at the end of the command. This seems to be the recommended (by GitHub) way to do it now anyways, I'm not sure why the instructions didn't do this before, unless this behavior wasn't supported by the very first implementation of SSH key signing in Git? 🤷‍♂️

(i.e. git config --global user.signingkey /PATH/TO/.SSH/KEY.PUB instead of git config --global user.signingkey 'ssh-ed25519 AAAAC3(...) user@example.com')

@jonaharagon jonaharagon merged commit b3a2671 into privacyguides:main Oct 14, 2023
4 checks passed
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-16/14435/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants