Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Fix/Shorten links, optimize svgs and lint #2435

Merged
merged 1 commit into from Mar 13, 2024

Conversation

kimg45
Copy link
Contributor

@kimg45 kimg45 commented Mar 10, 2024

Changes proposed in this PR:

  • fixed some outdated links for element
  • fixed broken links throughout the site
  • shortened/removed country specific parts of App Store links to make them country agnostic and save data
  • removed more language/country specific parts of URLs

I checked all the links to make sure they still work but feel free to double check.

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit aaa843d
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65f11ff0882ec900083e25af
😎 Deploy Preview https://deploy-preview-2435.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 74 (🔴 down 2 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kimg45 kimg45 marked this pull request as ready for review March 10, 2024 09:52
@freddy-m freddy-m changed the title update element links Update element links Mar 10, 2024
@kimg45 kimg45 marked this pull request as draft March 10, 2024 15:49
@kimg45 kimg45 changed the title Update element links Update/Fix links Mar 10, 2024
@kimg45 kimg45 marked this pull request as ready for review March 10, 2024 16:11
@kimg45 kimg45 marked this pull request as draft March 10, 2024 16:24
@kimg45 kimg45 marked this pull request as ready for review March 10, 2024 16:39
@kimg45 kimg45 changed the title Update/Fix links Update/Fix/Shorten links Mar 10, 2024
@dngray
Copy link
Member

dngray commented Mar 11, 2024

The wikipedia ones will need to be checked. In some cases other languages have very different articles which don't actually have much content. In that case it's probably better using translation services on the en article.

@kimg45
Copy link
Contributor Author

kimg45 commented Mar 11, 2024

You're right I just looked, re-added en.wikipedia.

@dngray dngray added the c:enhancements new features or other enhancements to the website itself label Mar 12, 2024
@dngray
Copy link
Member

dngray commented Mar 12, 2024

Just removed all trailing / and ran through lint which cleared some whitespace people had added (who don't use linters).

I wonder if we should also remove all instances of www maybe.

grep -r -P 'www.(?!w3|tempuri)([-\w]*\.)(?!w3|tempuri)\S*'

There's a few 😁

@dngray
Copy link
Member

dngray commented Mar 12, 2024

I did leave these ones alone, because I don't want to mess with SEO, and it's best to be consistent across whole site @jonaharagon?

I also didn't change other links like xmlns:

Or in license for mathjax

Funnily enough these two would not work with security.ssl.require_safe_negotiation set to true in Firefox:

Didn't support naked URL

Other than that I did fix a few things like tails.boum.org became tails.net and schub.io became overengineer.dev

@kimg45
Copy link
Contributor Author

kimg45 commented Mar 12, 2024

Wow really went above and beyond haha thanks!

@dngray
Copy link
Member

dngray commented Mar 12, 2024

Someone didn't read https://www.privacyguides.org/en/meta/uploading-images/#svg and I found some of these SVGs weren't optimized.

@dngray dngray force-pushed the pr-element-fix branch 3 times, most recently from bbd530b to 897a666 Compare March 13, 2024 03:07
@dngray dngray changed the title Update/Fix/Shorten links Update/Fix/Shorten links, optimize svgs and lint Mar 13, 2024
dngray added a commit to kimg45/privacyguides.org that referenced this pull request Mar 13, 2024
Tidies up a number of things:

- Outdated links that redirect
- Dead links
- Remove unnecessary parameters eg "en" and "en-US"
- Shortened amazon, apps.apple.com, reddit links
- Removed trailing /
- Remove www (except for PG assets)
- Optimize unoptimized SVGs
- Lint yaml, md files

Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
@dngray
Copy link
Member

dngray commented Mar 13, 2024

I've squashed this huge PR, because I have checked everything so far and it looks good.

LGTM, going to merge this so we don't have annoying conflicts coming in from other PRs.

dngray added a commit to kimg45/privacyguides.org that referenced this pull request Mar 13, 2024
Tidies up a number of things:

- Outdated links that redirect
- Dead links
- Remove unnecessary parameters eg "en" and "en-US"
- Shortened amazon, apps.apple.com, reddit links
- Removed trailing /
- Remove www (except for PG assets)
- Optimize unoptimized SVGs
- Lint yaml, md files

Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Tidies up a number of things:

- Outdated links that redirect
- Dead links
- Remove unnecessary parameters eg "en" and "en-US"
- Shortened amazon, apps.apple.com, reddit links
- Removed trailing /
- Remove www (except for PG assets)
- Optimize unoptimized SVGs and remove xml declarations
- Lint yaml, md files

Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit aaa843d into privacyguides:main Mar 13, 2024
3 of 4 checks passed
@kimg45 kimg45 deleted the pr-element-fix branch March 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:enhancements new features or other enhancements to the website itself
Development

Successfully merging this pull request may close these issues.

None yet

2 participants