New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/Fix/Shorten links, optimize svgs and lint #2435
Conversation
✅ Deploy Preview for privacyguides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The wikipedia ones will need to be checked. In some cases other languages have very different articles which don't actually have much content. In that case it's probably better using translation services on the en article. |
You're right I just looked, re-added en.wikipedia. |
Just removed all trailing I wonder if we should also remove all instances of
There's a few 😁 |
I did leave these ones alone, because I don't want to mess with SEO, and it's best to be consistent across whole site @jonaharagon?
I also didn't change other links like Or in license for mathjax Funnily enough these two would not work with
Didn't support naked URL Other than that I did fix a few things like tails.boum.org became tails.net and schub.io became overengineer.dev |
Wow really went above and beyond haha thanks! |
Someone didn't read https://www.privacyguides.org/en/meta/uploading-images/#svg and I found some of these SVGs weren't optimized. |
bbd530b
to
897a666
Compare
Tidies up a number of things: - Outdated links that redirect - Dead links - Remove unnecessary parameters eg "en" and "en-US" - Shortened amazon, apps.apple.com, reddit links - Removed trailing / - Remove www (except for PG assets) - Optimize unoptimized SVGs - Lint yaml, md files Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
I've squashed this huge PR, because I have checked everything so far and it looks good. LGTM, going to merge this so we don't have annoying conflicts coming in from other PRs. |
Tidies up a number of things: - Outdated links that redirect - Dead links - Remove unnecessary parameters eg "en" and "en-US" - Shortened amazon, apps.apple.com, reddit links - Removed trailing / - Remove www (except for PG assets) - Optimize unoptimized SVGs - Lint yaml, md files Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Tidies up a number of things: - Outdated links that redirect - Dead links - Remove unnecessary parameters eg "en" and "en-US" - Shortened amazon, apps.apple.com, reddit links - Removed trailing / - Remove www (except for PG assets) - Optimize unoptimized SVGs and remove xml declarations - Lint yaml, md files Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Changes proposed in this PR:
I checked all the links to make sure they still work but feel free to double check.