Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs links for various tools and make numerous other changes #2489

Merged
merged 1 commit into from Apr 8, 2024

Conversation

redoomed1
Copy link
Contributor

@redoomed1 redoomed1 commented Apr 5, 2024

Changes proposed in this PR:

  • Clean up links to documentation for a number of tools
    • For the following tools, change developer-focused docs links to FAQ links for the end user, given the intended audience of Privacy Guides: Firefox, addy.io, and NewPipe
    • Update Canary Mail, LibreTube, Proton Calendar, and Tuta (calendar) docs links
    • Add Obtainium and Fedora Atomic Desktop docs links
  • Make changes to Android page
    • Change "hardware security requirements" link under the GrapheneOS recommendation (current link simply points to a list of their currently supported devices)
    • Update ExifEraser link in the Secure Camera "Note" admonition (I noticed that the current one is broken because it does not provide an instant preview)
    • Change wording in F-Droid Basic admonition for improved readability
  • Make changes to Desktop Browsers and Browser Extensions pages
    • Apply changes from Update Firefox settings #2440 (tested in a fresh profile on Version 124.0.1)
    • Update mentions of "Firefox Accounts" to "Mozilla Accounts" and change link to their privacy policy in the "Telemetry" section
    • Change privacy policy link for uBlock Origin Lite (current one simply links to the privacy policy for uBlock Origin proper)
  • Make changes to Email Services and Email Clients pages
    • Update Proton Unlimited description to mention their family plan
    • "De-capitalize" any mentions of mailbox.org that are not at the beginning of a sentence to match how the service refers to itself in its documentation
    • Update email metadata link in the "Warning" admonition on the top of the Email Clients page (I noticed that the current one is broken because it does not provide an instant preview)
    • Change wording in the thunderbird-user.js description from "surface area" to "attack surface"
  • Make changes to Password Manager page
    • Remove the "Command-line" heading; incorporate its description into the gopass description; and append (CLI) next to the gopass heading and set its recommendation card to a third-level heading to match formatting in other pages such as the Email Clients page
  • Make minor grammatical changes otherwise not noted above
  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

Copy link

github-actions bot commented Apr 5, 2024

Your preview is ready!

Name Link
🔨 Latest commit a7a8817
😎 Preview https://a7a8817c215b--glowing-salamander-8d7127.netlify.app/

docs/android.md Outdated Show resolved Hide resolved
docs/desktop-browsers.md Outdated Show resolved Hide resolved
docs/email.md Outdated Show resolved Hide resolved
@jonaharagon
Copy link
Member

jonaharagon commented Apr 6, 2024

M71YIMPIvOwujoxD

You should rebase your commits in a PR instead of merging main into your branch btw https://www.privacyguides.org/en/meta/git-recommendations/#rebase-from-main-before-submitting-a-pr

or, if you don't use Git locally, don't bother and let us handle it :)

@redoomed1
Copy link
Contributor Author

or, if you don't use Git locally, don't bother and let us handle it :)

Understood, sorry about that. I have been using GitHub.com's web editor directly, and am still learning. Thanks for the feedback!

Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding https://github.com/privacyguides/privacyguides.org/pull/2489/files#r1554333828 I've decided that I do want proper nouns like Mailbox.org to be capitalized :)

docs/email.md Outdated Show resolved Hide resolved
docs/email.md Outdated Show resolved Hide resolved
docs/email.md Outdated Show resolved Hide resolved
docs/email.md Outdated Show resolved Hide resolved
docs/email.md Outdated Show resolved Hide resolved
Copy link
Member

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Jonah Aragon <jonah@triplebit.net>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit a7a8817 into privacyguides:main Apr 8, 2024
14 checks passed
@redoomed1 redoomed1 deleted the documentation-cleanup branch April 8, 2024 13:23
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-04-08-a1b01b8b/17776/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants