Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging information to DNS criteria #2509

Merged
merged 1 commit into from Apr 10, 2024
Merged

Add logging information to DNS criteria #2509

merged 1 commit into from Apr 10, 2024

Conversation

jonaharagon
Copy link
Member

Changes proposed in this PR:

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@jonaharagon jonaharagon requested a review from dngray April 10, 2024 08:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited

✅ Your preview is ready!

Name Link
🔨 Latest commit 662a3df
😎 Preview https://662a3dfeb564--glowing-salamander-8d7127.netlify.app/

@dngray dngray added the c:providers service providers and similar centralized/federated services label Apr 10, 2024
freddy-m
freddy-m approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dngray pushed a commit that referenced this pull request Apr 10, 2024
@jonaharagon @dngray
DNS: Add logging information/criteria (#2509)
a09474c 
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@jonaharagon @dngray
DNS: Add logging information/criteria (#2509)
662a3df 
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
dngray
dngray approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@dngray dngray left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I rather like the idea of combining the Privacy Policy column.

Was kind of worried about the width when I added the Signed Profile column.

@dngray dngray merged commit 662a3df into main Apr 10, 2024
28 checks passed
@dngray dngray deleted the dns-ctiteria-logs branch April 10, 2024 13:37
@redoomed1 redoomed1 mentioned this pull request Apr 10, 2024
Merged
4 tasks
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-04-10/17801/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddy-m freddy-m freddy-m approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
c:providers service providers and similar centralized/federated services
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

controld free plan (no logs?) dns0 has some logging
4 participants
@jonaharagon @privacyguides-bot @freddy-m @dngray