Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging footnote under Orbot card #2520

Merged
merged 1 commit into from Apr 13, 2024
Merged

Fix hanging footnote under Orbot card #2520

merged 1 commit into from Apr 13, 2024

Conversation

redoomed1
Copy link
Contributor

@redoomed1 redoomed1 commented Apr 13, 2024 •
edited

Changes proposed in this PR:

  • Fix the footnote providing links to context for the IsolatDestAddr preference in the Orbot recommendation
  • Under the "Additional Notes" section of the Proton VPN recommendation, replace external link to the Tor Project with an internal link to the Tor Browser card
  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 13, 2024 •
edited

✅ Your preview is ready!

Name Link
🔨 Latest commit f762b5c
😎 Preview https://2520--glowing-salamander-8d7127.netlify.app/

@redoomed1 @dngray
Correction: hanging link, use internal link (#2520)
f762b5c 
fix: hanging footnote orbot card
fix: external Tor Browser link to internal one

Signed-off-by: Jonah Aragon <jonah@triplebit.net>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit f762b5c into privacyguides:main Apr 13, 2024
8 checks passed
@redoomed1 redoomed1 deleted the fix-orbot-footnote branch April 13, 2024 14:42
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-04-14/17856/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@redoomed1 @privacyguides-bot @jonaharagon @dngray