Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the 2FA page #862

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Update the 2FA page #862

merged 1 commit into from
Apr 10, 2022

Conversation

TommyTran732
Copy link
Contributor

No description provided.

@opheron
Copy link
Contributor

opheron commented Apr 2, 2022

@TommyTran732 Hey, just a heads up I recently submitted PR #861 which also makes significant changes the 2FA article.

docs/android.md Outdated Show resolved Hide resolved
@dngray
Copy link
Member

dngray commented Apr 3, 2022

Feedback on the MFA article, would be don't make it too verbose or complex, as it is an entry article.

@TommyTran732 TommyTran732 changed the title Update the 2FA page (WIP) Update the 2FA page Apr 4, 2022
docs/multi-factor-authentication.md Outdated Show resolved Hide resolved
@dngray dngray added the t:correction content corrections or errors label Apr 4, 2022
@TommyTran732
Copy link
Contributor Author

Feedback on the MFA article, would be don't make it too verbose or complex, as it is an entry article.

Do you wanna split it into 2 pages then?

@TommyTran732
Copy link
Contributor Author

TommyTran732 commented Apr 4, 2022

IMO just recommending the Nitrokey and Yubikey and pretending that they are equal is not enough. The Nitrokey has the perk of integration with Heads and a built in password manager, but everything else it does is a lot worse than the Yubikey. Likewise, recommending hardware security keys over authenticator app or vice versa is not great either. It depends heavily on which exact protocol is being used and how the secrets are stored. Yubico OTP has worse privacy properties than TOTP for example, while FIDO2/U2F is superior to all of the other protocols. In general, storing TOTP secrets in hardware security key is preferable to using an app, but then the Nitrokey (which is recommended/mentioned on the page) doesn't encrypt those secrets, making it vulnerable to physical attacks and is a questionable recommendation at best.

I think the pros and cons of the protocols and the specific hardware keys should be made very clear, as they are crucial for doing threat modeling.

@realguyman
Copy link
Contributor

It should be noted that TOTP-based authentication is still vulnerable to phishing attacks.

And it should be noted that hardware security keys and services which adopt FIDO2/U2F are not vulnerable to phishing attacks.

@realguyman
Copy link
Contributor

If someone is going to purchase a hardware security key, it should be for FIDO2/U2F support.

Aegis Authenticator and other similar applications are secure enough for TOTP-based multi-factor authentication.

@TommyTran732
Copy link
Contributor Author

If someone is going to purchase a hardware security key, it should be for FIDO2/U2F support.

Aegis Authenticator and other similar applications are secure enough for TOTP-based multi-factor authentication.

Depends. Yes, that is the most common use case, but it is not always applicable.
Take the Nitrokey storage 2 for example. It is an okay PGP smartcard, it has system integrity verification integration with heads (this is unique to Nitrokeys), and encrypted password storage. It stores HOTP and TOTP secrets as well, tho they are not encrypted.

For certain use cases, it is okay as a hardware security key despite of the fact that it does not support FIDO2/U2F.

@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit e64a873
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/6252e5e871d84d0009cf1c30
😎 Deploy Preview https://deploy-preview-862--privacyguides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment on lines +321 to +322
- ![YubiKeys](/assets/img/multi-factor-authentication/yubikey.png){ .twemoji } [YubiKey](https://www.yubico.com/)
- ![Nitrokey](/assets/img/multi-factor-authentication/nitrokey.jpg){ .twemoji } [Nitrokey](https://www.nitrokey.com/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These images could be improved.

@jonaharagon jonaharagon added c:software self-hosted/decentralized software and related topics c:hardware relating to hardware recommendations and removed t:correction content corrections or errors labels Apr 6, 2022
dngray pushed a commit that referenced this pull request Apr 6, 2022
@dngray dngray force-pushed the 2fa branch 3 times, most recently from 4f3cd00 to 4257cf3 Compare April 6, 2022 14:53
dngray pushed a commit that referenced this pull request Apr 9, 2022
This was referenced Apr 9, 2022
dngray pushed a commit that referenced this pull request Apr 10, 2022
dngray pushed a commit that referenced this pull request Apr 10, 2022
@dngray dngray force-pushed the 2fa branch 2 times, most recently from 5c69302 to 1e3582f Compare April 10, 2022 13:55
@dngray dngray merged commit e64a873 into main Apr 10, 2022
@dngray dngray deleted the 2fa branch April 10, 2022 14:13
dngray pushed a commit that referenced this pull request Apr 10, 2022
Signed-off-by: Daniel Gray <dng@disroot.org>
@dngray dngray temporarily deployed to production April 10, 2022 14:14 Inactive
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/solokey-hardware-security-key/11585/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:hardware relating to hardware recommendations c:software self-hosted/decentralized software and related topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants