Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect XOR Operation in aggregatable-histogram creation #387

Open
hiratara opened this issue Jul 2, 2024 · 1 comment
Open

Incorrect XOR Operation in aggregatable-histogram creation #387

hiratara opened this issue Jul 2, 2024 · 1 comment
Labels
attribution-reporting Issues relating to the Attribution Reporting API documentation Improvements or additions to documentation

Comments

@hiratara
Copy link

hiratara commented Jul 2, 2024

Hello,

I wish to report an inconsistency in the Privacy Sandbox documentation regarding the bitwise operations in the Attribution Reporting API. The documentation states that XOR is used to combine source and trigger aggregation key-pieces , but in practice, OR is being used. This discrepancy leads to confusion and potential errors in implementation.

See: WICG/attribution-reporting-api#1353

It appears this might be an oversight that has yet to be addressed. I request that the documentation be updated to correctly reflect the actual behavior used in the implementation. Ensuring accurate documentation is crucial for developers relying on these specifications.

Please correct this error as soon as possible.

Thank you.

@hiratara hiratara added the attribution-reporting Issues relating to the Attribution Reporting API label Jul 2, 2024
@apasel422 apasel422 added the documentation Improvements or additions to documentation label Jul 2, 2024
@apasel422
Copy link
Collaborator

The documentation has been updated to point out that this is an error, but the error hasn't been corrected yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attribution-reporting Issues relating to the Attribution Reporting API documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants