Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hero section image grid #1092

Merged
merged 19 commits into from
Jun 5, 2023
Merged

fix: hero section image grid #1092

merged 19 commits into from
Jun 5, 2023

Conversation

Sanchitbajaj02
Copy link
Contributor

Related Issue

As mentioned in issue #1032, the home page image grid is not looking good on mobile screens. The issue I detected is related to the max-width issue and excessive use of absolute properties.

Description

To solve this issue, I first tried to remove all the dependencies related to absolute classes and use a grid to make 2 columns and align the content in them but to remove the existing code and rewrite it for all different screen sizes was kind of a hassle and disrespect to all the contributors who worked hard to create that section.
So, to fix that, I optimize the existing absolute classes for different screen sizes and gave a global max width class to set the content's max width.

Screenshots

Before

image

After

image

@vercel
Copy link

vercel bot commented Jun 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jun 5, 2023 6:24pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Sanchitbajaj02! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Sanchitbajaj02 Sanchitbajaj02 changed the title Fix: hero section image grid fix: hero section image grid Jun 4, 2023
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, please check the right side images problem

image

src/pages/HomePage.jsx Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC changes-required changes-required labels Jun 4, 2023
@Sanchitbajaj02
Copy link
Contributor Author

also, please check the right side images problem

image

can you tell on which screen size, does this issue occurred?

@priyankarpal
Copy link
Owner

also, please check the right side images problem

image

can you tell on which screen size, does this issue occurred?

1920 x 1080

@priyankarpal
Copy link
Owner

also, please check the right side images problem
image

can you tell on which screen size, does this issue occurred?

1920 x 1080

still same problem

@Sanchitbajaj02
Copy link
Contributor Author

I have reverted back the max-width part. Can we come on call if this still gives the same issue?

To reproduce this:-

image

I reduced the max-width manually. I couldn't get this same issue on the screens I have tested

@priyankarpal
Copy link
Owner

I have reverted back the max-width part. Can we come on call if this still gives the same issue?

To reproduce this:-

image

I reduced the max-width manually. I couldn't get this same issue on the screens I have tested

yeah

@Sanchitbajaj02
Copy link
Contributor Author

I have reverted back the max-width part. Can we come on call if this still gives the same issue?
To reproduce this:-

image

I reduced the max-width manually. I couldn't get this same issue on the screens I have tested

yeah

issue still occurring?

@priyankarpal
Copy link
Owner

I have reverted back the max-width part. Can we come on call if this still gives the same issue?
To reproduce this:-

image

I reduced the max-width manually. I couldn't get this same issue on the screens I have tested

yeah

issue still occurring?

nope but mobile view

I have reverted back the max-width part. Can we come on call if this still gives the same issue?
To reproduce this:-

image

I reduced the max-width manually. I couldn't get this same issue on the screens I have tested

yeah

issue still occurring?

Mobile view

image

Desktop view

Screenshot from 2023-06-04 16-11-23

@priyankarpal
Copy link
Owner

Have you reverted the changes? @Sanchitbajaj02

@priyankarpal priyankarpal added ❓ talk: question Further information is requested and removed changes-required changes-required labels Jun 5, 2023
@Sanchitbajaj02
Copy link
Contributor Author

Have you reverted the changes? @Sanchitbajaj02

I reverted the max-width problem that was occurring. I fix the card grid for 350 screen size and above

@priyankarpal priyankarpal removed the ❓ talk: question Further information is requested label Jun 5, 2023
@priyankarpal priyankarpal merged commit fdf03a1 into priyankarpal:main Jun 5, 2023
5 checks passed
@priyankarpal priyankarpal removed the projects addition add your projects label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants