-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: project addition/added js extension #1243
chore: project addition/added js extension #1243
Conversation
Signed-off-by: mohit parmar <100152343+mohitparmar1@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @mohitparmar1! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
Signed-off-by: Priyankar Pal <88102392+priyankarpal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add issue number to the PR description
sorry bro but I made pr without opening the issue |
In any open source projects, create an issue first after you get assigned, then create a PR. it's the best practice. Could you create an issue and add it to the PR description so I can merge it? Also, there are some conflicts error please resolve them |
Signed-off-by: mohit parmar <100152343+mohitparmar1@users.noreply.github.com>
issue #1316 and conflicts resolved! |
Signed-off-by: Priyankar Pal <88102392+priyankarpal@users.noreply.github.com>
Signed-off-by: Priyankar Pal <88102392+priyankarpal@users.noreply.github.com>
added leads-tracker extension on this project
issue #1316