Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: project addition/added js extension #1243

Merged
merged 7 commits into from
Jun 21, 2023

Conversation

mohitparmar1
Copy link
Contributor

@mohitparmar1 mohitparmar1 commented Jun 17, 2023

added leads-tracker extension on this project
issue #1316

Signed-off-by: mohit parmar <100152343+mohitparmar1@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jun 21, 2023 8:28am

@github-actions github-actions bot added projects addition add your projects wait for reviewers wait for the maintainer labels Jun 17, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @mohitparmar1! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Signed-off-by: Priyankar Pal  <88102392+priyankarpal@users.noreply.github.com>
@priyankarpal priyankarpal added no issue number contributor haven't added the issue number changes-required changes-required labels Jun 18, 2023
@priyankarpal priyankarpal changed the title project addition/added js extension chore: project addition/added js extension Jun 18, 2023
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add issue number to the PR description

@mohitparmar1
Copy link
Contributor Author

sorry bro but I made pr without opening the issue

@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC labels Jun 18, 2023
@priyankarpal
Copy link
Owner

priyankarpal commented Jun 18, 2023

Sorry bro but I made pr without opening the issue

In any open source projects, create an issue first after you get assigned, then create a PR. it's the best practice.

Could you create an issue and add it to the PR description so I can merge it? Also, there are some conflicts error please resolve them

@priyankarpal priyankarpal removed gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC labels Jun 20, 2023
Signed-off-by: mohit parmar <100152343+mohitparmar1@users.noreply.github.com>
@mohitparmar1
Copy link
Contributor Author

issue #1316 and conflicts resolved!

Signed-off-by: Priyankar Pal  <88102392+priyankarpal@users.noreply.github.com>
@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC and removed no issue number contributor haven't added the issue number changes-required changes-required labels Jun 21, 2023
Signed-off-by: Priyankar Pal  <88102392+priyankarpal@users.noreply.github.com>
@priyankarpal priyankarpal merged commit afe5c91 into priyankarpal:main Jun 21, 2023
6 checks passed
@priyankarpal priyankarpal removed gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
projects addition add your projects wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants