Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed unused social icons #1303

Merged
merged 7 commits into from
Jun 21, 2023
Merged

fix: Removed unused social icons #1303

merged 7 commits into from
Jun 21, 2023

Conversation

Sanchitbajaj02
Copy link
Contributor

Related Issue

In reference to issue #1226

Description

The issue was: in projects.json, some objects don't contain the social fields keys like Instagram or youtube. But in the component, this was not handled

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jun 21, 2023 5:08am

@github-actions github-actions bot added the wait for reviewers wait for the maintainer label Jun 20, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Sanchitbajaj02! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level2 mid level fix for GSSoC changes-required changes-required labels Jun 20, 2023
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit cff6559 into priyankarpal:main Jun 21, 2023
6 checks passed
@priyankarpal priyankarpal removed the changes-required changes-required label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 only for Girlscript summer of code level2 mid level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants