Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added IT Service Web-App #1367

Merged
merged 3 commits into from
Jun 25, 2023

Conversation

SyedImtiyaz-1
Copy link
Contributor

@SyedImtiyaz-1 SyedImtiyaz-1 commented Jun 24, 2023

Issue No. #1366

Hello @priyankarpal ,

Description-

It is a IT Solution website for the Students which are in the final year and those who need projects. 👍🏻

Screenshots -

Screenshot from 2023-06-25 00-38-46

Checklist for projects addition

  • My project has contribution guidelines.
  • My project has a Code of Conduct.
  • My project has a README file.
  • My project has a License.

Ready to Merge 👍🏻

@vercel
Copy link

vercel bot commented Jun 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jun 25, 2023 8:20am

@github-actions github-actions bot added projects addition add your projects wait for reviewers wait for the maintainer labels Jun 24, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SyedImtiyaz-1! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is essential that your projects include a contributing guide, code of conduct, license, and a readme. These requirements must be fulfilled without any exceptions.

@SyedImtiyaz-1
Copy link
Contributor Author

it is essential that your projects include a contributing guide, code of conduct, license, and a readme. These requirements must be fulfilled without any exceptions.

But this time I have followed the rules and just added the project under the rules and regulations.
If you think this is wrong then please tell me.

@priyankarpal
Copy link
Owner

it is essential that your projects include a contributing guide, code of conduct, license, and a readme. These requirements must be fulfilled without any exceptions.

But this time I have followed the rules and just added the project under the rules and regulations. If you think this is wrong then please tell me.

in your project you need to add contributing guide, license, readme, code of conduct after I can merge the PR

@SyedImtiyaz-1
Copy link
Contributor Author

SyedImtiyaz-1 commented Jun 24, 2023

Like this ? :
Screenshot from 2023-06-25 02-20-26

it is essential that your projects include a contributing guide, code of conduct, license, and a readme. These requirements must be fulfilled without any exceptions.

But this time I have followed the rules and just added the project under the rules and regulations. If you think this is wrong then please tell me.

in your project you need to add contributing guide, license, readme, code of conduct after I can merge the PR

@priyankarpal
Copy link
Owner

Like this ? : Screenshot from 2023-06-25 02-20-26

it is essential that your projects include a contributing guide, code of conduct, license, and a readme. These requirements must be fulfilled without any exceptions.

But this time I have followed the rules and just added the project under the rules and regulations. If you think this is wrong then please tell me.

in your project you need to add contributing guide, license, readme, code of conduct after I can merge the PR

yeah also, make sure to add Code of conduct & contributing guide

@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC changes-required changes-required and removed wait for reviewers wait for the maintainer labels Jun 25, 2023
@priyankarpal priyankarpal changed the title feat: Added IT Service Web-App chore: Added IT Service Web-App Jun 25, 2023
@priyankarpal priyankarpal linked an issue Jun 25, 2023 that may be closed by this pull request
7 tasks
@SyedImtiyaz-1
Copy link
Contributor Author

SyedImtiyaz-1 commented Jun 25, 2023

Hello @priyankarpal ,
Ihave followed the rules now.

Screenshot -

image

Now it is ready to merge 👍🏻

@priyankarpal priyankarpal removed the changes-required changes-required label Jun 25, 2023
@github-actions github-actions bot added the wait for reviewers wait for the maintainer label Jun 25, 2023
@priyankarpal priyankarpal merged commit cca9a70 into priyankarpal:main Jun 25, 2023
5 of 6 checks passed
@priyankarpal priyankarpal removed gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
projects addition add your projects wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: project addition by Imtiyaz
2 participants