Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Icons not showing on the docs page. #1568

Merged
merged 11 commits into from
Jul 5, 2023
Merged

fix: Icons not showing on the docs page. #1568

merged 11 commits into from
Jul 5, 2023

Conversation

adity2911
Copy link
Contributor

Related Issue

#1567

Description

Earlier the docs section had icons from react-feather that were not showing on the page because they are black by default. I have fixed it by making it white.

Screenshots

Before:
image
Adter:
image

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jul 4, 2023 6:55pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @adity2911! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Signed-off-by: Aditya Tulsiyan <72987111+adity2911@users.noreply.github.com>
Signed-off-by: Aditya Tulsiyan <72987111+adity2911@users.noreply.github.com>
Signed-off-by: Aditya Tulsiyan <72987111+adity2911@users.noreply.github.com>
Signed-off-by: Aditya Tulsiyan <72987111+adity2911@users.noreply.github.com>
@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC labels Jul 5, 2023
@priyankarpal priyankarpal changed the title Fix: Icons not showing on the docs page. fix: Icons not showing on the docs page. Jul 5, 2023
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit 88b4836 into priyankarpal:main Jul 5, 2023
6 of 9 checks passed
@adity2911 adity2911 deleted the dev/adity2911 branch July 5, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants