Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improved Docs Page Codebase #1579

Merged
merged 4 commits into from
Jul 5, 2023
Merged

refactor: Improved Docs Page Codebase #1579

merged 4 commits into from
Jul 5, 2023

Conversation

adity2911
Copy link
Contributor

Related Issue

#1517

Description

I have made the code easier to read and modular, based on the concept of DRY. This code is renders the exact same webpage as before, while also making it readable.
Lines of code halved from 427 to 261.

Screenshots

image

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jul 5, 2023 1:28pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @adity2911! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@priyankarpal
Copy link
Owner

I think currently we don't need to change anything. you're working on new feature

@priyankarpal priyankarpal added the 💬 talk: discussion Open for discussions and feedback label Jul 5, 2023
@adity2911
Copy link
Contributor Author

okay. well i thought you gave this issue a go after what you said at our discussion on issue #1517

Signed-off-by: Aditya Tulsiyan <72987111+adity2911@users.noreply.github.com>
@priyankarpal
Copy link
Owner

okay. well i thought you gave this issue a go after what you said at our discussion on issue #1517

you can close the PR & issue & just work on the #1519 also, we will change the codebase in docs page

@adity2911
Copy link
Contributor Author

well this is a part of the changes supposed to be made for issue #1519
If you could merge, It will be good for the 1519 issue.

@priyankarpal
Copy link
Owner

well this is a part of the changes supposed to be made for issue #1519 If you could merge, It will be good for the 1519 issue.

yeah I know but we will change the docs page UI & code then we need to change just work on that issue

@adity2911
Copy link
Contributor Author

adity2911 commented Jul 5, 2023

Kindly accept this as a level1 or 2 issue only. I have worked twice on the same issue.
It's a humble request.

@adity2911
Copy link
Contributor Author

Plus I was assigned this issue by you only.

@priyankarpal priyankarpal changed the title Refactor: Improved Docs Page Codebase refactor: Improved Docs Page Codebase Jul 5, 2023
app/docs/page.tsx Outdated Show resolved Hide resolved
Signed-off-by: Aditya Tulsiyan <72987111+adity2911@users.noreply.github.com>
@priyankarpal
Copy link
Owner

avoid to add these types of commits
image

@adity2911
Copy link
Contributor Author

Okay. Noted.

@priyankarpal
Copy link
Owner

Okay. Noted.

will merge soon

@priyankarpal priyankarpal linked an issue Jul 5, 2023 that may be closed by this pull request
@priyankarpal priyankarpal merged commit 5c4fe0f into priyankarpal:main Jul 5, 2023
6 checks passed
@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level2 mid level fix for GSSoC and removed 💬 talk: discussion Open for discussions and feedback labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 only for Girlscript summer of code level2 mid level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Improved docs page codebase
2 participants