New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get undefined dates in February #11
Comments
@bbkiwi Thanks for the report! That indeed seems to be a typo. I am curious to know what breaks because of this typo. I tried this on Chrome and it works just fine so I guess a browser compatibility issue. Either way, I will try to get a release out with a fix today. |
Also, what do you mean by the "cut down version in a ESP8266 project"? |
This fix is published to npm as v2.0.1. Thanks, @bbkiwi for the bug report. |
Hi Priyank, I responded via email to the above, but I don't think it's gone thru, so I'll put comments here again. With the spelling error, it works on my ipad (safari) except February is spelled incorrectly. However in FF 72.0.2 (64bit) it opens correctly but when the day is changed see screen shot. The ESP8266 project serves up files here: I'm not very familiar with JavaScript and npm. So I just grabbed the files from dist in your repo. Cheers, Bill |
Hello Bill, the reason the change does not show in the diff is that I update the dist folder during a new release. If you check master the dist should have the correct spelling. See 71d7dc8. The build process is simple. First, we compile typescript to javascript. We use typescript because it provides type checking. Next, we run it through babel to ensure somewhat older browsers can handle new features that are being used. Lastly, it is minified so it takes up fewer bytes! The build tool we use is Webpack which is pretty common to build the frontend assets. |
In the GitHub project you listed, here is the link showing the correct month in the dist folder: https://github.com/bbkiwi/LEDClock/blob/useMulti/data/dist/simplepicker.js#L116, which means it should work fine now. |
Nice code. Using a cut down version in a ESP8266 project. Noted that not working
for the month of February. It is because is spelled wrong.
In dist/simplepicker.js
e.exports={monthTracker:n,months:["January","Febuary",
should be
e.exports={monthTracker:n,months:["January","February",
The text was updated successfully, but these errors were encountered: