Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text-align center day abbreviations #2

Merged
merged 1 commit into from Oct 13, 2018
Merged

Text-align center day abbreviations #2

merged 1 commit into from Oct 13, 2018

Conversation

le717
Copy link
Contributor

@le717 le717 commented Oct 12, 2018

I am using simplepicker at work in a Bootstrap 4-powered site, and their CSS reset stylesheet resets the browser default text-align: center on <th> elements, which messes up the picker's appearance. All this PR does is add an explicit text-align: center on the th selector for day abbreviations so the appearance remains the same. A case could be made against this, but I'm of the thought that if I'm importing a library, it keeps an consistent appearance at all times. So visually, this change changes nothing but makes the design a little more bullet-proof.

Thank you for making this, BTW! I've been looking for a nice, jQuery/dependency-free datetime picker for a while and this is exactly what I've wanted. 馃槂

@priyank-p priyank-p merged commit 94838e5 into priyank-p:master Oct 13, 2018
@priyank-p
Copy link
Owner

Merged @le717! I will do a new release shortly :)

It's nice to hear you use it for work, I created it when I was also looking for picker without heavy dependencies free for reminder-app.

And about the text-align: center part it fine in this case since in my browser, latest chrome, it by default set to center by default so it an extra guard in appearance I guess.

@le717 le717 deleted the better-align-day-abbr branch October 13, 2018 00:20
@priyank-p
Copy link
Owner

Just published a new release to npm.

@le717
Copy link
Contributor Author

le717 commented Oct 13, 2018

Thank you very much! 馃槂

Thanks as well for the invitation to collaborate. Unfortunately, I must decline as I am currently unable to actively contribute due to other obligations. I appreciate the offer, however, and am greatly honored by the offer. 馃檪

@priyank-p
Copy link
Owner

Cool, No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants