Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twisted dependency missing? #140

Closed
mwoodbri opened this issue Feb 18, 2019 · 3 comments
Closed

twisted dependency missing? #140

mwoodbri opened this issue Feb 18, 2019 · 3 comments

Comments

@mwoodbri
Copy link

Describe the bug
v0.8.0 appears to be missing a dependency on twisted

To Reproduce

python3 -mvenv venv
. venv/bin/activate
pip install uplink
python -c 'from uplink import Consumer'

ModuleNotFoundError: No module named 'twisted'

Expected behavior
No ModuleNotFoundError

Additional context
The above steps work with v0.7.0
@prkumar prkumar mentioned this issue Feb 18, 2019
Merged
@prkumar
Copy link
Owner

prkumar commented Feb 18, 2019

@mwoodbri - Thanks for reporting this! I just opened #141 to remove this mandatory dependency. This post release fix should go live within the hour -- after then, you should be able to import v0.8.0 without this issue.

@prkumar
Copy link
Owner

prkumar commented Feb 18, 2019

Just confirmed that this is fixed now after the recent post release. Thanks again, @mwoodbri!

@prkumar prkumar closed this as completed Feb 18, 2019
@mwoodbri
Copy link
Author

Brilliant. Now working for me. Thank you @prkumar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwoodbri @prkumar