Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PxrTexture breaks when material node has colon in name #638

Closed
breadbyte opened this issue Nov 11, 2021 · 7 comments
Closed

PxrTexture breaks when material node has colon in name #638

breadbyte opened this issue Nov 11, 2021 · 7 comments

Comments

@breadbyte
Copy link

Steps to reproduce:

  1. Open blender.
  2. Select the default cube.
  3. Add a RenderMan nodetree to it. I used PxrDisneyBsdf as the material.
  4. Add a PxrTexture node as the base color.
  5. Add an image. It should appear.
  6. Add a colon to the material name.
  7. Change the image. Any changes to the image will not appear.
  8. Remove the colon. An image must be set again for it to appear.
@prman-pixar
Copy link
Owner

Thanks for the report. We're currently using the material name as part an ID for the texture manager. Clearly this won't work if you rename the material. We'll have to come up with a better strategy for creating an ID for each texture in the texture manager.

@prman-pixar
Copy link
Owner

prman-pixar commented Dec 9, 2021

I believe I have fixed this issue. Unfortunately, this is too late to get into the upcoming 24.3 release, but it will be available once 24.4 ships.

@fxjeane
Copy link

fxjeane commented Feb 10, 2022

I just synced to the latest in master and I can see the issue when rendering with Blender 3.0. The issue still happens whenever the material is renamed.

@prman-pixar
Copy link
Owner

@fxjeane Yes, the fix will be in 24.4. Currently, I don't have an ETA of when that will ship, unfortunately.

@fxjeane
Copy link

fxjeane commented Feb 10, 2022

I see. The issue is with PRMan, and not on the Blender add-on?

@prman-pixar
Copy link
Owner

Yes, it's a problem with some of the core python modules in PRMan.

@prman-pixar
Copy link
Owner

This issue should now be considered fixed with the release of RenderMan 24.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants