Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from internal frames to a tabbed panel to manage multiple graphs #21

Closed
EJBQ opened this issue Jan 14, 2015 · 5 comments
Closed
Labels
feature A feature request
Milestone

Comments

@EJBQ
Copy link
Contributor

EJBQ commented Jan 14, 2015

As part of this change:

  • Refactor the toolbar to be a classic Swing toolbar
  • Add labels to tools in the toolbar
@EJBQ EJBQ added feature A feature request gui labels Jan 14, 2015
@prmr prmr added this to the Release 0.2 milestone Jan 15, 2015
@prmr prmr modified the milestones: Release 0.3, Release 0.2 Jan 25, 2015
@prmr prmr changed the title Change from windowed to tabbed diagrams Change from internal frames to a tabbed panel to manage multiple graphs Feb 7, 2015
@JoelChev JoelChev self-assigned this Feb 25, 2015
@JoelChev
Copy link
Contributor

@EJBQ For this issue, I will work with you, but I think I will work on adding labels and overall redesigning the toolbar during Milestone 4.

@EJBQ EJBQ assigned EJBQ and JoelChev and unassigned JoelChev and EJBQ Feb 25, 2015
@EJBQ
Copy link
Contributor Author

EJBQ commented Feb 25, 2015

That sounds fine.

@JoelChev
Copy link
Contributor

JoelChev commented Mar 3, 2015

@EJBQ @prmr The TabbedView is starting to come along! I invite you both to check it out and play with it a bit. I have yet to look into adding a splash screen (so on launch there is nothing on display, you have to add a tab to start interacting with JetUML). If there are any important features that I have not ported over yet, please let me know and I will look into them.

Some important changes:
-To close an open tab, you can either hit CTRL-W or go File->Close to close the current tab. If the GraphPanel in the current tab has been modified, it will launch a YES/NO OptionPane to confirm that you want to close the tab
-The Window menu of JetUML has been ripped out (as you don't need to resize windows or close them anymore).

For now, I am treating tabs as JInternalFrames (so either GrameFrames or an eventual WelcomeFrame splash tab as we discussed last week). If either of you feel that I should change this to a different Swing component (JPanel or something), please let me know and I can change this quickly. Thanks!

@JoelChev
Copy link
Contributor

Alright, I have added X "Close" buttons to the Tabs in JetUML now. By clicking on an X, that designated tab will automatically close if it hasn't been modified, or will prompt the user with a message if it has been modified. Please let me know what you guys think of this feature, I can remove it if you don't like it.

@EJBQ
Copy link
Contributor Author

EJBQ commented Mar 11, 2015

This seems to be working correctly to me. The X works just like the closing normally, seems solid. I'll look into the code more, but the functionality seems solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A feature request
Projects
None yet
Development

No branches or pull requests

3 participants