Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

furnace: Refacored the queue implementation #10

Merged
merged 4 commits into from
Dec 24, 2020
Merged

furnace: Refacored the queue implementation #10

merged 4 commits into from
Dec 24, 2020

Conversation

onprem
Copy link
Owner

@onprem onprem commented Dec 24, 2020

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Refactored the queue implementation

Verification

Added unit tests

@coveralls
Copy link

coveralls commented Dec 24, 2020 •
edited
Loading

Coverage Status

coverage: 93.878% (+7.5%) from 86.364%
when pulling 3fb9dff on furnace-queue
into 870d8eb on main.

someshkoli
someshkoli reviewed Dec 24, 2020
View reviewed changes
Copy link
Collaborator

@someshkoli someshkoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pkg/furnace/furnace.go Show resolved Hide resolved
@onprem onprem merged commit 95ea3c0 into main Dec 24, 2020
@onprem onprem deleted the furnace-queue branch December 24, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@someshkoli someshkoli someshkoli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onprem @coveralls @someshkoli