-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for natural tabbing experience #10
Comments
The reason it's focusing the entire thing is because you can use the arrow keys to choose dates, and shift/alt + arrow keys to switch month/year, so really it's for switching everything. I wouldn't really want three tabs to get to that mode |
If there is just one tab focus for the entire picker, then we should consider removing the month & year dropdowns from the tabIndex and have a single tab focus that relies on the keyboard controls that you've defined. Do you think users will intuit that they can use the shift key to change the month/year controls while in the day selection zone? This is the alternative approach I am lobbying for, which gives each of those controls separate focus, with natural arrow key navigation (ditched the tabbing individual day idea in the original description) |
I did consider that, and I really like the idea of having just one tabbable element, but no I don't think it's intuitive enough (though I'd love to be wrong) |
Can you take a look at the draft PR when you have a chance - I added a tabIndexed div for the calendarDay section and left the shift-functionality in place for that area of the widget. here is the the happy path for tabbing:
^-- this should provide intuitive keyboard support for users who haven't encountered the widget before. https://github.com/probablykasper/date-picker-svelte/pull/11/files |
Still not sure about this, but sure I'll check it out |
I think I'll keep it the way it is. The two ideas above get confusing when you end up tabbing to a previous element |
I noticed Google Calendar actually doesn't tab into the calendar at all. Maybe that would be a good option? |
This came up for me while testing ISSUE#1
Currently when you tab into the date picker, the entire picker is selected and you can start left-right-up-down navigating through dates but there is no visual clue that a user could start doing this. Then the tab moves to the year, and then month.
Proposal:
When you tab into the picker:
I will throw together an experimental PR
The text was updated successfully, but these errors were encountered: