-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an npm package #2
Comments
I will take a look at it in a couple days when I have the time to, since I haven't made an npm package before. Out of interest, would you also be interested in this being published to wally (package manager for roblox)? Also, if you could tell me more information about your workflow so I can replicate it, that would be much appreciated, by this I mean: What editor are you using, how are you integrating with roblox (rojo), I assume you are using roblox-ts at some point? |
I never use Wally and I think npm is enough. As well some methods are missing e.g. .Add .Mul .Pow etc. |
I've created an npm package Also, regarding your second comment, these do have functions, they are I have never used roblox-ts, so I can't confirm whether or not the types work, I just add them for people who use roblox-ts and requested them. If you know how to add metatable methods into roblox-ts I think they could help other people who use this library also :) |
Thank you! It's interesting that you have .d.ts file and you are not using the Roblox TS. About TS you can still set the metametods but you not able to use something like Vector3 + Vector3 so you have to use macros like Vector3.add(Vector3) at the end it compiles to +. There's no implementations of these macros for classes for now so it's better to add the methods like add mul div etc. I think. For Roblox TS you have to tell in the .d.ts file that the parameters like . magnitude exist, it's not about the metatables but more about the types interface ITest{
Test1(): void // compiles to object:Test1()
Test2: () => void // compiles to object.Test2()
} |
I downloaded roblox-ts just to help fix this issue, I expect it to be finished within ~2 hours because I want to overhaul some metamethods to support strict typing within roblox studio (as a major revision). I apologize for the original delay in getting to this issue and hope I can make the roblox-ts experience much better :) |
Thank you a lot for this. Not everyone will decide to try ts just to expand the reach to his package. |
I believe all of your concerns have now been addressed with the release of v2.0.2! If you have any problems let me know, otherwise I will be closing this issue as completed :). |
You can as well make an announcement in the RobloxTS server to get more people to download the package |
btw why you didnt join rbxts, it will not be considered as valid package |
No worries, I will take a look at it |
Issues have now been addressed in the latest release. :) |
Could you pls create an npm package for @rbxts since it was written / just typed for typescript?
The text was updated successfully, but these errors were encountered: