Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spaces between equal sign for html attributes #162

Merged
merged 2 commits into from
Mar 10, 2018

Conversation

Jonarod
Copy link
Contributor

@Jonarod Jonarod commented Mar 10, 2018

Even with regex and comments supporting whitespaces between attributes and values (<tag key = val />), the code itself does not account for these spaces and includes them into final strings generating inconsistent parsing like "foo instead of foo or class instead of class...

I added very lightweight change to trim() leading and trailing spaces if any.
See #161

Plus I wrote test cases to prevent any future regression.

@codecov
Copy link

codecov bot commented Mar 10, 2018

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files           1        1           
  Lines         328      328           
  Branches       47       47           
=======================================
  Hits          327      327           
  Misses          1        1
Impacted Files Coverage Δ
index.js 99.69% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2d2f51...6be39a8. Read the comment docs.

Copy link
Owner

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Makes perfect sense

@quantizor quantizor merged commit 3191b49 into quantizor:master Mar 10, 2018
@quantizor
Copy link
Owner

I’ll probably release this tomorrow when I have some free time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants