Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relying on .name attribute of rv_discrete #122

Open
fsaad opened this issue Jan 31, 2022 · 0 comments
Open

Fix relying on .name attribute of rv_discrete #122

fsaad opened this issue Jan 31, 2022 · 0 comments

Comments

@fsaad
Copy link
Collaborator

fsaad commented Jan 31, 2022

The .name attribute of a frozen rv_discrete.dist object does not correspond to the underlying class, i.e.,

>>> from scipy.stats import norm
>>> d = norm(loc=0, scale=1)
>>> d.dist.name
'norm'

>>> from scipy.stats import rv_discrete
>>> d = rv_discrete(values=((1, 2), (.5, .5))).freeze()
>>> d.dist.name
'Distribution'

This behavior will cause issue in serializing, since we rely on the name attribute to correspond to a scipy class:
https://github.com/probcomp/sppl/blob/efff34fb3d3703247dd7001c36970069c5ac3825/src/compilers/spe_to_dict.py#L48

Related #121

The constructor of rv_discrete does accept a name attribute, which will need to be handled correctly when loading the scipy dist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant