Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prune_events from BranchSPN and make ProductSPN check for conjunctions first #57

Closed
fsaad opened this issue Apr 16, 2020 · 1 comment

Comments

@fsaad
Copy link
Collaborator

fsaad commented Apr 16, 2020

Rather than iterate through all 2^m subsets, first compute the probabilities of the m conjunctions and immediately return 0 if each conjunction in the union has probability zero, which removes the duplicate computation inside prune_events.

@fsaad
Copy link
Collaborator Author

fsaad commented Apr 19, 2020

Implemented in 4ac7d47 for logprob---condition is more complicated, since finding the disjoint union is often more expensive than the linear pruning, plus we already memoize those computations

@fsaad fsaad closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant