Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean out debugger code #2454

Open
Yatekii opened this issue May 10, 2024 · 4 comments
Open

Clean out debugger code #2454

Yatekii opened this issue May 10, 2024 · 4 comments

Comments

@Yatekii
Copy link
Member

Yatekii commented May 10, 2024

The debugger code has grown tremendously and we really need to clean it up.
Currently not even cargo fmt understands it :O

@bugadani
Copy link
Contributor

We should define some goals here, or we'll have another eternally open issue.

@Yatekii
Copy link
Member Author

Yatekii commented May 10, 2024

Yeah, the idea is that we kind of make sub issues (or more precise ones). Those are only for a rough overview :)

@bugadani
Copy link
Contributor

bugadani commented May 11, 2024

Fair, but cleaning up is a fractal task. No matter what we do, there's always more. To make this more focused, IMO, we should agree upon a set of principles to follow, criteria to meet, and then we can start asking for that from ourselves and from contributors.

@Yatekii
Copy link
Member Author

Yatekii commented May 11, 2024

Oh yeah it would be very nice to define some metrics.
If you have good ideas that would be nice, but I would say of the top of my head for me that would be:

  • Functions 30-50 lines max
  • Max 2 indentations excluding trait and function impl base ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants