Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket.io-encrypt incompability #521

Open
ExQDev opened this issue Mar 10, 2021 · 2 comments
Open

Socket.io-encrypt incompability #521

ExQDev opened this issue Mar 10, 2021 · 2 comments
Labels
enhancement 🚀 New feature or request

Comments

@ExQDev
Copy link

ExQDev commented Mar 10, 2021

Vuex integration and $socket.$subscribe does not work with socket.io-encrypt. It returns raw encrypted data, but $socket.client.on returns decrypted data.
Please, add compability to use both of these plugins with vuex actions.

@probil
Copy link
Owner

probil commented Mar 10, 2021

Hi @ExQDev
That issue is rather from socket.io side. There is no easy way to subscribe to all events. vue-socket.io-extended and socket.io-encrypt use two different incompatible approaches for that. Having something like middleware on socket.io side could have helped a lot.

I went through the code of socket.io-encrypt and by now I don't see any easy solution to combine these two. I'd think more about it. Maybe I missed something. 🤔 The solution might be by utilizing socket.io v3 which has something similar to middlewares I mentioned but it would require some changes to both socket.io-encrypt and vue-socket.io-extended (already planned)

BTW Any particular reason to have this kind of encryption? I thought using secured version of the protocol (e.g. https:// or wss://) would suffice since data sent over the wire is encrypted with TLS thus a proxy servers couldn't read it

@ExQDev
Copy link
Author

ExQDev commented Mar 10, 2021

Perhaps secured version of the protocol is nice practice, but for now this is the best solution for my project, 'cause dev version should to be secured too.

@probil probil added the enhancement 🚀 New feature or request label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants