Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of delta updates #1

Open
srevinsaju opened this issue Sep 9, 2020 · 9 comments
Open

Possibility of delta updates #1

srevinsaju opened this issue Sep 9, 2020 · 9 comments

Comments

@srevinsaju
Copy link

Is it possible to provide the *.zsync file to ease updates? I am not familiar with pkg2appimage

@probonopd
Copy link
Owner

It can for Travis CI but not yet for GitHub Actions.

One would have to add to appimagetool https://github.com/AppImage/AppImageKit/blob/bc5a03a0e59651bb39018f77e378c44a4cba7a5e/src/appimagetool.c#L876-L905 for GitHub Actions in addition to Travis CI.

Like I did in go-appimage here:

https://github.com/probonopd/go-appimage/blob/7fab45552eb485c0076fd310835fa7958f981de0/src/appimagetool/appimagetool.go#L547-L567

Do you want to try adding this to appimagetool?

@probonopd
Copy link
Owner

Alternatively, one could make pkg2appimage use go-appimage's appimagetool...

@srevinsaju
Copy link
Author

srevinsaju commented Sep 9, 2020

In my "workaround"-ish brain, I would have unpacked the Zoom AppImage generated using pkg2appimage and then repack it using appimagetool with --updateinformation flag to point to the continuous release. Would it be ok? If it would be, I can create a PR.

@probonopd
Copy link
Owner

probonopd commented Sep 9, 2020

appimagetool -g is supposed to do this, since manually passing --updateinformation has proven to be too error-prone for many people to get it right. (Hence, in my no go-based implementation there will be no way to specify it manually.)

@srevinsaju
Copy link
Author

hmm. but I prefer doing everything manually. Thanks for the info about the -g flag. I will try my luck at adding Github Actions support on https://github.com/AppImage/AppImageKit/blob/bc5a03a0e59651bb39018f77e378c44a4cba7a5e/src/appimagetool.c#L876-L905

@probonopd
Copy link
Owner

I prefer doing everything manually.

You are probably one of the few people who are willing to spend enough time to actually understand what an update information string is... ;)

@srevinsaju
Copy link
Author

@probonopd in case you missed it, AppImage/AppImageKit#1075 aims at adding GH Actions support to the appimagetool

@probonopd
Copy link
Owner

Excellent @srevinsaju. Let's use it here once it's merged there.

@srevinsaju
Copy link
Author

Great. Thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants