-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt for probot v11. Use @actions/core
for logging
#19
Conversation
BREAKING CHANGE: package name has been renamed to "@probot/adapter-github-actions" BREAKING CHANGE: the package now has the same export as `"probot"`. Before ```js const runProbot = require('probot-actions-adapter'); const app = require('./index'); runProbot(app); ``` After ```js const { run } = require("@probot/adapter-github-actions"); const app = require("./app"); run(app); ```
@swinton this is basically a total rewrite, I'd appreciate if you could have a look. If we decide to merge, I'd deprecate the current |
@actions/core
for logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work here, @gr2m. I love the new name as well! I had one README suggestion...
``` | ||
|
||
### Example `action.yml` | ||
Then use `index.js` as your entrypoint in the `action.yml` file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bit more nuance here to unpack.
Users can either:
- Commit their node_modules
- Compile their JS down to a single executable script (e.g. via
@vercel/ncc
-- this is my preference)
Perhaps we can lean on the docs to unpack this nuance: https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github
Then use `index.js` as your entrypoint in the `action.yml` file | |
Follow the official GitHub documentation for next steps including: | |
1. [Creating an action metadata file](https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#creating-an-action-metadata-file) | |
1. [Commit, tag, and push your action to GitHub](https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay like this? 6760bd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #16
BREAKING CHANGE: package name has been renamed to "@probot/adapter-github-actions"
BREAKING CHANGE: the package now has the same export as
"probot"
.Before
After
View rendered LICENSE.md
View rendered README.md