Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue was released #13

Open
thojansen opened this issue Oct 31, 2017 · 4 comments
Open

fix for issue was released #13

thojansen opened this issue Oct 31, 2017 · 4 comments

Comments

@thojansen
Copy link

When someone creates an issue on a given project, it is common to close this issue once a PR is merged e.g. into master. However, this fix may be released at a later point in time. It would be awesome if a bot could notify on the issue once referenced commits are part of a new GitHub release.

@j-f1
Copy link

j-f1 commented Nov 17, 2017

How does this look?

When a release is published

  • For each issue #mentioned in the release description or closed by being #mentioned in a PR #mentioned in the release:
    • comment This has been fixed in ${release.tag.name}! :tada:
  • For each pull request #mentioned in the release:
    • comment This has been released as part of ${release.tag.name}! :tada:
  • For each issue or pull request #mentioned in the release:
    • add the ${release.tag.name} label to the issue
    • (optional) lock the issue, and include the message I’m locking this issue since it has been resolved. If it resurfaces, please [open a new issue](https://github.com/foo/bar/issues/new) and tell us about it. in the comment posted.

@thojansen
Copy link
Author

Yes, that looks about right. Maybe the label could also be optional. Any comments from others if this would be useful?

@rsarky
Copy link

rsarky commented Mar 16, 2018

@zeke Maybe we could extend the functionality of release-notifier to also comment on issues that have been fixed as a part of a release?

Also @j-f1 suggested:

For each issue or pull request #mentioned in the release:
add the ${release.tag.name} label to the issue
(optional) lock the issue, and include the message I’m locking this issue since it has been resolved. If it resurfaces, please open a new issue and tell us about it. in the comment posted.

I think this would also be a neat addition.

@zeke
Copy link

zeke commented Mar 16, 2018

Good call, @rsarky. I've opened an issue here: release-notifier/release-notifier#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants