Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow making new pull requests directly through comments in an issue #41

Open
vaibhavchellani opened this issue Feb 15, 2018 · 10 comments

Comments

@vaibhavchellani
Copy link

Allow users to make a PR by specifying the details of a PR and simply clicking the comment button which will post the PR , the comment , and link the issue and PR directly .

@jainkeval
Copy link

jainkeval commented Feb 27, 2018

I would like to work on this.

@vaibhavchellani
Copy link
Author

I would like to work on this too

@gr2m
Copy link
Contributor

gr2m commented Feb 27, 2018

I’m curious what you come up with

@jainkeval
Copy link

jainkeval commented Mar 11, 2018

https://github.com/apps/pr-on-comment check this :-)

GitHub
GitHub is where people build software. More than 27 million people use GitHub to discover, fork, and contribute to over 80 million projects.

@gr2m
Copy link
Contributor

gr2m commented Mar 11, 2018

@jainkeval I’ll check it out :)

What’s usually very helpful is to create a gif of how the bot works. You can use the free Kap app to record a gif: https://getkap.co/

E.g. see my WIP bot for an example: https://github.com/apps/wip

Kap
An open-source screen recorder built with web technology
GitHub
GitHub is where people build software. More than 27 million people use GitHub to discover, fork, and contribute to over 80 million projects.

@gr2m
Copy link
Contributor

gr2m commented Mar 11, 2018

Tried it at gr2m/sandbox#31, no luck. Do you a repository where I can see it working?

@jainkeval
Copy link

jainkeval commented Mar 11, 2018

@gr2m there is nothing to compare where you are trying.
image

Yeah, you may fork this repo https://github.com/jainkeval/trial-one. Push your changes to fork and then comment.

GitHub
Contribute to trial-one development by creating an account on GitHub.

@gr2m
Copy link
Contributor

gr2m commented Mar 11, 2018

sweet, worked now: gr2m/sandbox#32 👍

@jainkeval
Copy link

jainkeval commented Mar 12, 2018

@gr2m What am I supposed to do now?

@gr2m
Copy link
Contributor

gr2m commented Mar 12, 2018

@vaibhavchellani do you have any feedback for @jainkeval? Maybe you two want to collaborate to make it better?

I don’t have a use for that bot myself so I can’t give much more feedback I’m afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants