-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
probot-translate-comments #45
Comments
This is an awesome idea! I'd love to see auto-detect so that it just works passively. Maybe a config file to denote the destination language for that repo, so that it isn't always translating to English by default? And even using |
Hi @JasonEtco, Thanks for taking time to read this through. I didn't like the idea of config file as it's kinda intrusive to the codebase, I mean JS world is going #0CJS lol. I guess you misunderstood the closed issue thingy. So the maintainer can create an issue with some format, which probot app can fetch and parse to get required stuff. This way it doesn't affect the code base/commit lot and can be tweaked by updating that closed issue.
|
Typically, config files for GitHub/Probot Apps are stored in the repo's Personally, I'd rather have my project's config as part of the codebase than somewhere in an issue that is liable to get lost, but its up to you 🤷♂️ For what its worth, |
Oh, I wasn't aware that we already use config files in certain cases, in that case let's go with a config file. Yeah, the issue thing is kinda hacky anyway. Regarding defaults, while English is good enough, we can probably do slight search to figure that out as well. The major pain point would be to detect what language given string is in. Once we settle for its logic/npm module, we can use same on, umm, commit history, to find top language and use it as target/destination language. Sounds good? |
That'd be really, really cool! Since it'd be per repo, and you wouldn't want to do that search on every comment, you'd probably want to have the app make a PR adding the config file when its installed. This also has the benefit of introducing the maintainers to the app, and to have them check to make sure that the proposed language is correct, as a second human check. |
Amazing! Plan:
This bot would do a lot of work;
|
Hi! My teammate @Akshitaag and I would love to take this issue up as a part of our RGSoC proposal! |
Yes, we would love to work on this issue. @gr2m what are your thoughts? |
Sure, fee free to add it to your submission :) |
@Rahmeen14 @Akshitaag was any submission made on this?. If it's a work in Progress I'd love to contribute. |
Hi @vidu171 ! |
Detect language of commenter/OP and translate it using Google translate/Bing, or at least post link to it (if APIs aren't open/rate limited).
Default languages (not to translate) can stored as a closed issue, which the bot can look up for.
Something like:
"probot/translate-comments/default-languages en-us,es"
The text was updated successfully, but these errors were encountered: