Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull_request.converted_to_draft event is missing in current version of @octokit/webhooks #1483

Closed
plainheart opened this issue Mar 9, 2021 · 3 comments

Comments

@plainheart
Copy link

Bug Report

Hi, dear Probot team,

There is an event for pull_request.converted_to_draft, it might be newly added.
By reading the documentation and source code, it does have this event.
So, can we upgrade webhooks to the latest version or any version after 7.21.0, for example, 7.22.0?

BTW, 7.24.0 also provides another two new events pull_request.auto_merge_{enable,disable} . It would be better to upgrade to this version.

Current Behavior

module.exports = (app) => {
  app.on(['pull_request.converted_to_draft'], async context => {
    app.log.info('Received event converted_to_draft', context)
  })
};

Got a hint from @octokit/webhooks like this

"pull_request.converted_to_draft" is not a known webhook name (https://developer.github.com/v3/activity/events/types/)

Expected behavior/code

No hint about unknown webhook name.

Environment

  • Probot version(s): The latest version 11.1.0
  • Node/npm version: Node 14 / npm 7
  • OS: Windows 10

Possible Solution

Upgrade @octokit/webhooks library.

Thank you!

@welcome
Copy link

welcome bot commented Mar 9, 2021

Thanks for opening this issue. A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@plainheart
Copy link
Author

Oh, sorry that I just see #1481 is doing it.

@wolfy1339
Copy link
Collaborator

The reason the version is pinned and at the version it is at currently is because of some breaking changes in the way the payload types are generated.

The last compatible version was v7.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants