-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add logging options #1645
Conversation
Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved. |
Can we add this change to the framework please? |
This comment was marked as spam.
This comment was marked as spam.
For some reason, the tests aren't completing here, which prevents merging this PR. @sugarshin Can you try rebasing this so the tests get triggered again? |
1799e64
to
da7cdaa
Compare
@AaronDewes I rebased now. but, seems tests are not triggered. could you help? |
Yes, I could trigger them now. I'll merge this later unless someone else objects. |
@AaronDewes any update? |
@AaronDewes thanks! how do I know when a new release with this change will be available? |
Probot has automated releases, so it's been available since the minute this PR was merged: |
What
Enable to receive pino-http option to logging-middleware.
Why
For example, may need to exclude some endpoints even if normally want to handle all access logs (e.g. health check endpoint). And, It may also be useful for developers to be able to specify other options.