Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add logging options #1645

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

sugarshin
Copy link
Contributor

@sugarshin sugarshin commented Feb 8, 2022

What

Enable to receive pino-http option to logging-middleware.

Why

For example, may need to exclude some endpoints even if normally want to handle all access logs (e.g. health check endpoint). And, It may also be useful for developers to be able to specify other options.

@sugarshin sugarshin requested a review from a team as a code owner February 8, 2022 11:30
@welcome
Copy link

welcome bot commented Feb 8, 2022

Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@roi-orca
Copy link

Can we add this change to the framework please?

@roi-orca

This comment was marked as spam.

@AaronDewes
Copy link
Member

For some reason, the tests aren't completing here, which prevents merging this PR. @sugarshin Can you try rebasing this so the tests get triggered again?

@sugarshin
Copy link
Contributor Author

@AaronDewes I rebased now. but, seems tests are not triggered. could you help?

@AaronDewes
Copy link
Member

Yes, I could trigger them now. I'll merge this later unless someone else objects.

@roi-orca
Copy link

@AaronDewes any update?

@AaronDewes AaronDewes merged commit 6c5840d into probot:master Jan 16, 2023
@welcome
Copy link

welcome bot commented Jan 16, 2023

Thanks for your contribution to probot! 🎉
Congrats!

@roi-orca
Copy link

@AaronDewes thanks! how do I know when a new release with this change will be available?

@AaronDewes
Copy link
Member

@AaronDewes thanks! how do I know when a new release with this change will be available?

Probot has automated releases, so it's been available since the minute this PR was merged:
grafik

@sugarshin sugarshin deleted the add-logging-option branch January 30, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants