Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): simplify ProbotWebhooks object #1833

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

vscaiceanu-1a
Copy link
Contributor

Should fix #1815

@vscaiceanu-1a vscaiceanu-1a requested a review from a team as a code owner June 13, 2023 15:42
@welcome
Copy link

welcome bot commented Jun 13, 2023

Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@gr2m
Copy link
Contributor

gr2m commented Jun 13, 2023

I'm not sure how this PR changes anything? I approved running the tests but unfortunately there are tons of errors. I don't have the time to look into that I'm afraid, I'm happy to merge pull requests that have passing tests and don't introduce breaking changes though

@AaronDewes
Copy link
Member

I'm not sure how this PR changes anything? I approved running the tests but unfortunately there are tons of errors. I don't have the time to look into that I'm afraid, I'm happy to merge pull requests that have passing tests and don't introduce breaking changes though

I have locally confirmed this fixes compilation Errors with Typescript 5. Considering this basically changes nothing, it seems like a bug in TS 5, but I have not yet submitted a report there.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the TS errors do not seem related to this pull request. We can merge it and figure out the test errors separately

@gr2m gr2m merged commit 7b09369 into probot:master Jun 14, 2023
2 of 11 checks passed
@welcome
Copy link

welcome bot commented Jun 14, 2023

Thanks for your contribution to probot! 🎉
Congrats!

@github-actions
Copy link

🎉 This PR is included in version 12.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Soosay86

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Probot isn't compatible with latest typescript
4 participants