-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use readFileSync
and JSON.parse
instead of require
in probot-receive
#1891
fix: use readFileSync
and JSON.parse
instead of require
in probot-receive
#1891
Conversation
You could, but I don't think it's an issue, maybe some people even want to generate the payload with JS here. |
@AaronDewes |
@gr2m What's your opinion on this? |
That was never an intended use. I'd go ahead with this change, if someone shows up complaining that we broke their use case, we can discuss it then. It's a problem when it's a problem |
readFileSync
and JSON.parse
instead of require
in probot-receive
Just for clarification: you want feedback by @AaronDewes before you merge, or is there something to do by me? |
I'd like to wait to get @AaronDewes' approval for only supporting JSON moving forward. Is this a blocker? |
Not a blocker. Just better to be clear what the next steps are ;) |
🎉 This PR is included in version 13.0.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I guess you could actually load arbitrary code into probot receive cli command.