Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: derive Server log from Probot log #1924

Merged
merged 1 commit into from
Nov 18, 2023
Merged

fix: derive Server log from Probot log #1924

merged 1 commit into from
Nov 18, 2023

Conversation

wolfy1339
Copy link
Collaborator

Fixes #1490

@wolfy1339 wolfy1339 added the bug label Nov 18, 2023
@wolfy1339 wolfy1339 requested a review from a team as a code owner November 18, 2023 00:53
@wolfy1339 wolfy1339 requested a review from gr2m November 18, 2023 01:41
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, adding a test would be great, but no worries if that's too much work. The errors seem unrelated. Should we maybe only fix this in v13?

@wolfy1339
Copy link
Collaborator Author

It is an easy patch to switch it to v13. I have no preference either way.

How would one go about adding a test for this?

@gr2m
Copy link
Contributor

gr2m commented Nov 18, 2023

It is an easy patch to switch it to v13. I have no preference either way.

let's do v13 then. When in doubt, whatever is easier for maintainers

How would one go about adding a test for this?

good point, I didn't think this through :) It'd be rather complicated, no worries then

@wolfy1339 wolfy1339 changed the base branch from master to beta November 18, 2023 23:11
@wolfy1339 wolfy1339 enabled auto-merge (squash) November 18, 2023 23:13
@wolfy1339 wolfy1339 merged commit 122740b into beta Nov 18, 2023
17 checks passed
@wolfy1339 wolfy1339 deleted the fix-server-logging branch November 18, 2023 23:17
Copy link

🎉 This PR is included in version 13.0.0-beta.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logLevel is ignored when using Probot Server
2 participants