Use JSON file for config instead of YAML

[JasonEtco]

Hot take: JSON is easier to parse/work with in a JS environment than YAML. I think (and @bkeepers can confirm) that since Probot is largely a GitHub-related endeavour, YAML was chosen because config files are a standard in Ruby/Rails (and GitHub things). However, since we're living in JS world I think it makes more sense to swap over to JSON. At the very least, we could test to see if it ends in .json and treat it differently that way.

🔥🔥🔥 🚒

[gr2m]

YAML files are easier to change by hand. As the configuration files are currently mostly edited by people, I’d keep the YAML format.

[bkeepers]

YAML files are easier to change by hand. As the configuration files are currently mostly edited by people, I’d keep the YAML format.

☝️ this is probably the most compelling reason I think it makes sense to stick with YAML for now.

At the very least, we could test to see if it ends in .json and treat it differently that way.

I'm not opposed to this, but I think we should hold out on changing it until changes are implemented based on #258.

[rtsao]

Config loading is already encapsulated in Probot, therefore shouldn't YAML be equally easy to work with in a JS environment? What benefit is there to switching to JSON?

I think YAML is a better choice than JSON for the following reasons:

1. YAML supports comments; JSON does not
2. YAML is more easily read/edited by humans than JSON
3. JSON git diffs have significantly more noise than YAML diffs
4. JSON is less opinionated when it come to valid formatting which can exacerbate the above point

The only reason I can think of for using JSON is that parsing JSON is faster and doesn't require a dependency, but that doesn't seem like a worthwhile tradeoff.

While we're bike shedding this, might as well propose using https://github.com/toml-lang/toml 😆

[JasonEtco]

Alright, clearly the people have spoken! Thanks for talking it over everyone, I'll close this out now.